Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default granted consents #159

Closed
wants to merge 1 commit into from
Closed

Update default granted consents #159

wants to merge 1 commit into from

Conversation

Hlavtox
Copy link
Contributor

@Hlavtox Hlavtox commented Feb 20, 2024

Questions Answers
Description? Adds default granted consents to make sure all data is allowed to flow into GA.
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? https://support.google.com/tagmanager/answer/13695607
Sponsor company
How to test?

@Hlavtox Hlavtox added this to the 5.0.1 milestone Feb 20, 2024
kpodemski
kpodemski requested changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@kpodemski kpodemski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It cannot work like that. It should be denied by default, and granted when user consents.

It is not responsibility of the Analytics module to handle consent/cookie banners fully.

@Hlavtox Hlavtox closed this Feb 21, 2024
@Hlavtox
Copy link
Contributor Author

Hlavtox commented Feb 21, 2024

PR not needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpodemski kpodemski kpodemski requested changes

Assignees
No one assigned
Labels
waiting for author
Projects
PR Dashboard
Archived in project
Milestone
5.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Hlavtox @kpodemski @ps-jarvis