Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A potential information reveal problem #44

Open
JacksonWuxs opened this issue Sep 11, 2019 · 0 comments
Open

A potential information reveal problem #44

JacksonWuxs opened this issue Sep 11, 2019 · 0 comments

Comments

@JacksonWuxs
Copy link

JacksonWuxs commented Sep 11, 2019

I am following your framework and extend your work by adding "attention". However, when I review your code, I am confuse that whether you calculated the first principle component with training data or not? If you calculate the first principle component with current dataset (test data), it seems that you introduce some information to create the sentence embeddings for test datasets. In that case, your result may not be accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant