-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefer Continued Destination Signs #3258
Comments
Is this a backend issue or should this be done on the client side? I remember @freenerd talking about implementing (or wanting to implement) destination consolidation for text instructions. |
Well. I kind of feel like at least this situation described (at some point) needs to be server side. When we handle destination lanes, we are supposed to find the correct one. The turn described here is essentially a case where we would want to guide the driver into the correct destination lane to begin with (even though specified as destination tags only). So if we ever add support for destination lane tags, finding the correct lane could depend on handling this on the server. Since we have to implement it at the server at some time, we should probably consider handling it on normal destination signs already. |
Companion ticket for frontend compilation Project-OSRM/osrm-text-instructions#30 We do want to continue to emit everything that is on the destination sign (e.g. |
This means we can't do it in the backend's post-processing then. |
Or we have to find a way how to incorporate destination lanes. The problem at the respective intersection is that the destination is only specified for the turn as a whole, not on a per lane basis but you need to select the correct lane. |
cc @pratikyadav for context. |
I think this is an Slicing the information off on the server side would just remove information for the client that might be useful for display purposes. |
Closing in favor of Project-OSRM/osrm-text-instructions#115 |
on this route, we give two different destinations.
At the very first part, we have two destinations
MacArther Boulevard;San Pablo Avenue
, on the second turn we only haveSan Pablo Avenue
.In cases like these, we should prefer sticking to a single destination rather than using
MacArther
on the first andSan Pablo
on the second turn.This could be done in post-processing to check direction information that follows close after another for common strings and stick to these.
The text was updated successfully, but these errors were encountered: