Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

about page is overflowing due to long unbroken text #174

Open
thescientist13 opened this issue Jan 28, 2025 · 10 comments
Open

about page is overflowing due to long unbroken text #174

thescientist13 opened this issue Jan 28, 2025 · 10 comments
Labels
bug Something isn't working docs Greenwood specific content like docs and guides good first issue Good for newcomers

Comments

@thescientist13
Copy link
Member

The Docs->About page has a string of text under the Import Attributes section that has no breaks in it, and is this using the page to scroll horizontally on mobile.

Image

Looks to have been introduced in #153
@thescientist13 thescientist13 added bug Something isn't working docs Greenwood specific content like docs and guides good first issue Good for newcomers labels Jan 28, 2025
lschierer added a commit to lschierer/www.greenwoodjs.dev that referenced this issue Jan 28, 2025
@lschierer
Update docs.css
3662619 
fixes ProjectEvergreen#174 by allowing the text to break mid-word.
@BDFL669
Copy link

BDFL669 commented Jan 28, 2025

I'd be happy to help with this task

@thescientist13
Copy link
Member Author

Hey @BDFL669 , yeah that would be great! Currently discussing approaches in #175 (comment) so if you have a good solution to this, by all means feel free to submit a PR. 🙌

@thescientist13 thescientist13 linked a pull request Jan 29, 2025 that will close this issue
fix oversized code block within an li tag #175
Closed
@BDFL669
Copy link

BDFL669 commented Jan 29, 2025 via email

@BDFL669
Copy link

BDFL669 commented Jan 31, 2025

I think 'break' makes more sense but I don't mind experimenting with the other solutions and try them on different screen sizes. I've already deployed the app locally though

@thescientist13
Copy link
Member Author

Thanks @BDFL669 , yeah I think playing around with a couple different options and seeing what the results are would be helpful.

@BDFL669
Copy link

BDFL669 commented Feb 4, 2025 via email

@thescientist13
Copy link
Member Author

Thank you so much, glad you like the project! And indeed, Next.js was a big influence on me while creating Greenwood. 😊

There a couple good first issues here in this repo if you want to jump into helping out on our website, and I saw you joined our Discord so I can reach out to you there about ideas for other contributing ideas like you said.

Let me know if that sounds good and thanks for wanting to be part of the community!

@BDFL669
Copy link

BDFL669 commented Feb 5, 2025 via email

@thescientist13
Copy link
Member Author

thescientist13 commented Feb 5, 2025 •
edited
Loading

@BDFL669
If you're referring to #176 let's have that conversation over in that issue to keep this one focused on the overflow issue 👍

@BDFL669
Copy link

BDFL669 commented Feb 5, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working docs Greenwood specific content like docs and guides good first issue Good for newcomers
Projects
[Greenwood] Website Redesign and Relaunch
Status: 🔖 Ready
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix oversized code block within an li tag lschierer/www.greenwoodjs.dev
2 participants
@thescientist13 @BDFL669