Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: honor last used msa and key for signin #116

Merged

Conversation

JoeCap08055
Copy link
Contributor

@JoeCap08055 JoeCap08055 commented Mar 1, 2024

Description

This PR adds the ability for the app to remember the MSA and public key last used for sign-in, and pre-select it in the account selection page if present.

  • Add new browser local store, CachedLastUsedMsaAndAddress store to save MSA and public key address last used for sign-in
  • Change CurrentSelectedMsaAccountStore from storable to writable, as we don't need to cache this in the browser any more
  • Honor previous selection if present

Closes #18

@JoeCap08055 JoeCap08055 requested a review from enddynayn March 1, 2024 14:20
Copy link
Contributor

@enddynayn enddynayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice!

@JoeCap08055 JoeCap08055 merged commit 621f08d into main Mar 1, 2024
3 checks passed
@JoeCap08055 JoeCap08055 deleted the 18-enhancing-user-recall-for-account-login-in-dapps branch March 1, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancing User Recall for Account Login in dApps
2 participants