From aac4e024e6dfa215cb5c92de472aa014bf0b1e94 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Germ=C3=A1n?= <german.m.podesta@gmail.com>
Date: Thu, 13 Oct 2022 20:12:40 -0300
Subject: [PATCH] 64 mal comportamiento del filtro de tags y ofertas inactivas
 (#552)

* Added pytest as a runner

* Added pytest as a runner on Makefile

* Added joboffers app

* Some fixes to the JobOffer model

* Added initial joboffer detail

* Added initial job offer add form

* Changed joboffer's urls to use their namespace

* Added some basic pytest's fixtures

* Updated JobOffer's factory to include all the needed fields

* Added joboffer creation test

* Added joboffer admin page

* Moved add button to bottom of the page (joboffers)

* Added search button in admin page (joboffers)

* Added joboffer edit view

* Changed joboffer's choices to their long version

* Fixed javascript filtering tags for joboffers

Co-authored-by: Juan Manuel Schillaci <jmschillaci@gmail.com>
Co-authored-by: Ian Puchetti <ianpuchetti@gmail.com>
---
 community/templates/_tags_filtering_form.html    | 10 ++++++----
 joboffers/templates/joboffers/joboffer_list.html |  2 +-
 static/js/tag_filtering.js                       |  6 ++++++
 3 files changed, 13 insertions(+), 5 deletions(-)

diff --git a/community/templates/_tags_filtering_form.html b/community/templates/_tags_filtering_form.html
index 4a834f12..efdf71de 100644
--- a/community/templates/_tags_filtering_form.html
+++ b/community/templates/_tags_filtering_form.html
@@ -6,15 +6,17 @@
                 <div class="input-group col-md-12">
                     <input type="search" name="search" placeholder="Buscar ofertas..." class="form-control input-lg" value="{% if search %}{{search}}{% endif %}">
                     <span class="input-group-btn">
-                        <button class="btn btn-default btn-lg" type="submit">
+                        <button id="buscar" class="btn btn-default btn-lg" type="submit">
                             {% trans 'Buscar' %}
                         </button>
                     </span>
                 </div>
                 <div class="ma-5" style="margin-top:15px;">
-                    <input name="active" type="hidden" value="{% if not active %}true{% else %}false{% endif %}">
-                    <input type="checkbox"  style="vertical-align: top;" onclick="this.form.active.value=!JSON.parse(this.form.active.value);this.form.submit();" {% if not active %} checked {% endif %}>
-                    <span>{% trans 'Mostrar solo ofertas activas' %}</span>
+                  <label>
+                    <input name="active" type="hidden" value="{{ active|yesno:'false,true' }}">
+                    <input id="show-active" type="checkbox" {% if not active %}checked{% endif %} />
+                    {% trans 'Mostrar solo ofertas activas' %}
+                  </label>
                 </div>
         </article>
         <header class="list-group-item">
diff --git a/joboffers/templates/joboffers/joboffer_list.html b/joboffers/templates/joboffers/joboffer_list.html
index 6054ec36..4f348ad7 100644
--- a/joboffers/templates/joboffers/joboffer_list.html
+++ b/joboffers/templates/joboffers/joboffer_list.html
@@ -22,7 +22,7 @@ <h4>
                     </h4>
                     <p>{{ object.short_description}}</p>
                     <div class="text-muted">
-                    {% include "jobs/_jobs_tags.html" %}
+                    {% include "joboffers/_tags.html" %}
                       <p><a href="{{ object.get_absolute_url }}">{% trans 'Leer más...' %}</a></p>
                     </div>
                 </div>
diff --git a/static/js/tag_filtering.js b/static/js/tag_filtering.js
index 26cc0342..63b9ccfe 100644
--- a/static/js/tag_filtering.js
+++ b/static/js/tag_filtering.js
@@ -32,3 +32,9 @@ $("#tags-form").submit(function() {
     ).prop('disabled', true);
     return true;
 });
+
+
+$("#show-active").click(function() {
+    this.form.active.value=this.checked;
+    $("#buscar").click();
+});