Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's add Dead Link Checker to CI/CD #355

Closed
AndreiCherniaev opened this issue Aug 28, 2024 · 2 comments
Closed

Let's add Dead Link Checker to CI/CD #355

AndreiCherniaev opened this issue Aug 28, 2024 · 2 comments

Comments

@AndreiCherniaev
Copy link

AndreiCherniaev commented Aug 28, 2024

Should we add Dead Link Checker to QXlsx CI/CD? For example this code contains dead link... For example we can use this checker.

My log

a@Asya:~/QXlsx$ lychee QXlsx/source/* -m 0
  37/37 ━━━━━━━━━━━━━━━━━━━━ Finished extracting links                                                                                                                                                                                       Issues found in 4 inputs. Find details below.

[QXlsx/source/xlsxdocpropscore.cpp]:
✗ [ERR] http://www.w3.org/2001/XMLSchema-instance | Failed: Too many redirects: error following redirect for url (http://www.w3.org/2001/XMLSchema-instance)
✗ [ERR] http://purl.org/dc/elements/1.1/ | Failed: Too many redirects: error following redirect for url (http://purl.org/dc/elements/1.1/)
✗ [ERR] http://purl.org/dc/dcmitype/ | Failed: Too many redirects: error following redirect for url (http://purl.org/dc/dcmitype/)
✗ [ERR] http://purl.org/dc/terms/ | Failed: Too many redirects: error following redirect for url (http://purl.org/dc/terms/)

[QXlsx/source/xlsxworksheet.cpp]:
✗ [ERR] http://a.com/aaa.html#aaaaa | Failed: Network error: error sending request for url (http://a.com/aaa.html#aaaaa)

[QXlsx/source/xlsxformat.cpp]:
✗ [ERR] http://office.microsoft.com/en-001/excel-help/create-a-custom-number-format-HP010342372.aspx | Failed: Too many redirects: error following redirect for url (http://office.microsoft.com/en-001/excel-help/create-a-custom-number-format-HP010342372.aspx)

[QXlsx/source/xlsxdocument.cpp]:
✗ [ERR] http://en.wikipedia.org/wiki/Open_Packaging_Conventions | Failed: Too many redirects: error following redirect for url (http://en.wikipedia.org/wiki/Open_Packaging_Conventions)

🔍 37 Total (in 0s) ✅ 5 OK 🚫 7 Errors 💤 25 Excluded
@xakod
Copy link
Contributor

xakod commented Nov 4, 2024

You report contains some false positive errors
http://www.w3.org/2001/XMLSchema-instance
http://a.com/aaa.html#aaaaa
http://en.wikipedia.org/wiki/Open_Packaging_Conventions
3 of 7 errors are false positive. Maybe it's a good idea but not in current implementation

@j2doll
Copy link
Member

j2doll commented Feb 10, 2025

Thank you for a good report and idea! 🥇

I had no idea about dead links. 🐵

If you don't have any further comments, I'll keep this issue closed for now. You can reopen it later.

@j2doll j2doll closed this as completed Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants