Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 path being printed in Launcher tab #70

Open
nileshvd opened this issue Jan 13, 2025 · 1 comment
Open

S3 path being printed in Launcher tab #70

nileshvd opened this issue Jan 13, 2025 · 1 comment

Comments

@nileshvd
Copy link

Tested in SageMaker JupyterLab, as well as local installation of JupyterLab

When I start navigating a bucket, the navigation path gets printed in Launcher tab. Even when I dont navigate the string S3: gets printed.

Expected
Launcher tab to not see the S3 path

Screenshot 2025-01-08 at 8 59 43 AM

@DenisaCG
Copy link
Member

Thanks for opening this issue.

The s3 prefix is used when creating the custom encompassing drive for the DriveBrowser. The s3 path gets displayed at the top of the Launcher tab, as it is connected to the DriveBrowser. The behaviour is the same when using the default FileBrowser, without the prefix s3 (this can be observed by opening a new Launcher from the default FileBrowser).

This is also related to the temporary solution we merged for having the Launcher work with the DriveBrowser, #61. It uses the IFileBrowserFactory to track the current file browser used and defaults to the DriveBrowser when first launching JupyterLab as it get the recently added file browser, if none was in focus. Once we have the Launcher functionalities fixed upstream, the path will still be displayed, but it will either be the local one from the default FileBrowser or the s3 one from the DriveBrowser.

Here is the issue where we are discussing the Launcher behaviour: #45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants