From f71db545d51428c4b7ea788f0028e48fc94b00d5 Mon Sep 17 00:00:00 2001 From: trlkly Date: Sun, 8 Dec 2019 05:53:57 -0600 Subject: [PATCH 1/4] Better fix for missing sidebar More idiomatic fix for Issue #37. It uses jQuery within the proper file, just before adding the sidebar base. It also directly tests the DOM to see if the "small-2" column is missing, rather than just guessing using the URL. --- assets/js/modules/dom-modifier.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/assets/js/modules/dom-modifier.js b/assets/js/modules/dom-modifier.js index 5eaad63..ade3571 100644 --- a/assets/js/modules/dom-modifier.js +++ b/assets/js/modules/dom-modifier.js @@ -120,6 +120,10 @@ export default class DomModifier { $('#news, #newspost').replaceWith(''); + if (comicDirective.parent().siblings('.small-2').length === 0) { + // There's no column after the comic: Insert our own + comicDirective.parent().after('
'); + } comicDirective.parent().siblings('.small-2').prepend(''); // Set a base (required by Angular's html5Mode) From eb23f4e67a8e0f7f99735cd3c4a20469c8b1b510 Mon Sep 17 00:00:00 2001 From: trlkly Date: Sun, 8 Dec 2019 05:58:03 -0600 Subject: [PATCH 2/4] Update version. No new features, just a bug fix , so only upped minor version number. --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 87da27b..0e4afa7 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "questionable-content-spa", - "version": "0.6.0", + "version": "0.6.1", "description": "Questionable Content Single-Page Application with Extra Features", "main": "app.js", "scripts": { From bbfbf9cc77fc6569c41cc5640e23098992107b6d Mon Sep 17 00:00:00 2001 From: trlkly Date: Sun, 8 Dec 2019 06:03:01 -0600 Subject: [PATCH 3/4] Update version Minor version upped because bugfix--no new features --- package-lock.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package-lock.json b/package-lock.json index 542ddca..a1dd67e 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "questionable-content-spa", - "version": "0.6.0", + "version": "0.6.1", "lockfileVersion": 1, "requires": true, "dependencies": { From 2c8b30b213aa53daf3315e26967619663bcfea8c Mon Sep 17 00:00:00 2001 From: trlkly Date: Sun, 8 Dec 2019 06:07:34 -0600 Subject: [PATCH 4/4] Update changelog to include description of fix Per Issue #37. --- assets/templates/changeLog.html | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/assets/templates/changeLog.html b/assets/templates/changeLog.html index fc508ff..0b406d0 100644 --- a/assets/templates/changeLog.html +++ b/assets/templates/changeLog.html @@ -36,7 +36,10 @@

NextVersion NextDate

  • --> - +

    0.6.1 December 8, 2019

    +
      +
    • Fix missing sidebar when loading a comic directly by number in URL.
    • +

    0.6.0 March 7, 2019