Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable editors to pre-publish comic info #79

Open
phuzion opened this issue Sep 15, 2023 · 2 comments
Open

Enable editors to pre-publish comic info #79

phuzion opened this issue Sep 15, 2023 · 2 comments
Assignees
Labels
functional-enhancement Improves the code or internal functionality, but is imperceptible to end user

Comments

@phuzion
Copy link

phuzion commented Sep 15, 2023

Some editors (namely myself) may have advance knowledge of comic metadata, due to subscribing on Patreon. These editors should be able to add the next day's comic into the database ahead of time.

Some considerations I've thought of:

  • Enable the editor to manually add the next day's comic to the database with a UI element
  • Comics created in the database by an editor (rather than the script) should be in a hidden state, only viewable to those with editor keys
  • The script that currently adds each day's comic should check if the comic exists in the database, and if it does, it should simply unhide the existing comic metadata, rather than creating a new row
  • Editors with keys should have the ability to publish/unpublish comics (aka show or hide them from regular viewers), perhaps limit to the most recent 5 comics for standard editor keys?
  • Editors with keys should have a client-side switch to show or hide unreleased comic info (aka spoiler a spoiler toggle)

There are probably some other considerations that would need to be thought through, but I don't exactly have a solid understanding of how the backend system works here. Happy to discuss here or via DM any of these ideas.

@ilyvion ilyvion self-assigned this Sep 16, 2023
@ilyvion ilyvion added the functional-enhancement Improves the code or internal functionality, but is imperceptible to end user label Sep 16, 2023
@ilyvion
Copy link
Contributor

ilyvion commented Sep 16, 2023

  • Editors with keys should have the ability to publish/unpublish comics (aka show or hide them from regular viewers), perhaps limit to the most recent 5 comics for standard editor keys?

It's unclear to me what this is about. Why should editors have the power to override the publish state of comics at all? Either they've been published (i.e. the script that detects new comics has run), and the data should be visible to regular users or they haven't been published, and their data shouldn't be visible to regular users.

@phuzion
Copy link
Author

phuzion commented Sep 18, 2023

My thought was that an editor should be able to force-publish the comic, in the event that they happen to catch the comic going live between runs of the script. And unpublishing would be in case someone were to accidentally publish a comic by mistake (say, for example, while editing tomorrow's comic using information from Patreon).

Perhaps an alternate solution would be a way to fire off an event that runs the script to check if the comic is published or not, but I would imagine that would be even more complicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
functional-enhancement Improves the code or internal functionality, but is imperceptible to end user
Projects
None yet
Development

No branches or pull requests

2 participants