Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#38 resizeable obs dialog #139

Merged
merged 14 commits into from
Aug 2, 2024
Merged

#38 resizeable obs dialog #139

merged 14 commits into from
Aug 2, 2024

Conversation

PhillipsOwen
Copy link
Collaborator

this addresses issue #38

Draft for now. i am not entirely impressed with the resize package i used,

@PhillipsOwen PhillipsOwen marked this pull request as draft August 1, 2024 12:06
Copy link
Member

@mbwatson mbwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it feels a little funny how it wants to stay centered, but it works pretty well. i noticed there are minConstraints and maxConstraints props in the react-resizable docs that might help control the size of the dialog.

@PhillipsOwen
Copy link
Collaborator Author

i just put a fix into the code to allow the obs dialog to expand beyond 600px.

also, i believe that the odd handle dragging behavior may be related to the dialog being moveable (no anchor point).

@PhillipsOwen PhillipsOwen marked this pull request as ready for review August 2, 2024 14:27
@PhillipsOwen PhillipsOwen requested review from mbwatson and removed request for lstillwe August 2, 2024 14:28
@PhillipsOwen PhillipsOwen merged commit da0ac9d into main Aug 2, 2024
@PhillipsOwen PhillipsOwen deleted the #38-resizeable-obs-dialog branch August 2, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants