-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#173 split screen #195
#173 split screen #195
Conversation
…split-screen # Conflicts: # src/components/trays/help-about/helpAboutTray.js
for some reason my implementation of getting the SLD config for each layer stopped working. i converted the layer loading to use useState(). that resulting in the map not resetting properly. |
…issues by implementing useEffect(). tidying up comments, control layouts, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
first, it works great. i haven't gotten into the code too much, as i've been poking around the UI trying to test functionality, and i haven't been able to break it. however, i noticed that the model selection dropdowns over in the other tray don't seem to function on this branch.
i had tweaked the zindex this morning thinking it would be straight-forward but it wasnt. i un-did that update and will be addressed in another PR. please pull this branch again. |
* @param productType | ||
* @returns {JSX.Element} | ||
*/ | ||
const getLayerIcon = ( productType )=> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we do something like this quite a bit in this app. i'm thinking this function could probably live in uselayers for everyone to use. it wouldn't have to be done in this PR necessarily, of course, but a nice function to have around.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff!
addresses issue #173 .
this branch has been tested, is stable and can be advertised as "experimental" in order to draw out answers to questions as listed in issue #196 .