mui material and mui joy integration in the app #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbwatson
approved these changes
May 8, 2024
There was a problem hiding this comment.
glad this workaround exists. it does rub me the wrong way to be honest, but it lets you keep moving, so 👍 .
i think we should consider imposing a rule that no one uses any mui/material components so removing it is easy when we're able to build this dialog without mui/material. it adds a big chunk to the bundle, too, having this in there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mui material and mui joy integration in the app
modified the "ProvisionedApp" definition to integrate the mui/material and mui/joy providers in the app.
please see https://mui.com/joy-ui/integrations/material-ui/ for implementation details.
the big caveat here:
Once Joy UI reaches component parity with Material UI, we recommend that you choose one or the other. Not only do they have a different design language (and therefore a different theme structure) but they would increase your bundle size as well as potentially create unnecessary complexities.