Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model selection - Correcting the date handling #298

Merged
merged 4 commits into from
Oct 21, 2024

Conversation

PhillipsOwen
Copy link
Collaborator

@PhillipsOwen PhillipsOwen commented Oct 14, 2024

Addresses issue #297

Removing the clearing of the date in state because that is handled in the control itself.

@PhillipsOwen PhillipsOwen requested a review from lstillwe October 14, 2024 18:10
@PhillipsOwen PhillipsOwen marked this pull request as draft October 16, 2024 16:11
@PhillipsOwen
Copy link
Collaborator Author

after review, LS caught this:

  • Go to synoptic tab
  • Select a date
  • Select a cycle
  • Hit Submit
  • Hit Reset

Try to pick another date - The control has not been reset properly so a new date cant be selected.

@PhillipsOwen PhillipsOwen marked this pull request as ready for review October 21, 2024 21:06
Copy link
Contributor

@lstillwe lstillwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing find!

@lstillwe lstillwe merged commit 030713c into main Oct 21, 2024
@lstillwe lstillwe deleted the issue-297-model-selection-date-hndlr branch October 21, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants