Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine how best to display TeleIRC version flag #346

Closed
Tjzabel opened this issue Oct 15, 2020 · 2 comments · Fixed by #352
Closed

Determine how best to display TeleIRC version flag #346

Tjzabel opened this issue Oct 15, 2020 · 2 comments · Fixed by #352
Assignees
Labels
improvement Improves on something that already exists research Research and more data is needed to make a decision
Milestone

Comments

@Tjzabel
Copy link
Member

Tjzabel commented Oct 15, 2020

Summary

Every time we make a new release of TeleIRC, we need to make sure we are also updating the TeleIRC versioning flag.

Background

Is your improvement related to a problem? Please describe:

Users were confused on our latest v.2.0.1 release, as our versioning flag still says v2.0.

Describe the solution you'd like:

We need to make sure our versioning flag correctly reflects the most up to date release. Therefore, this should always be the latest change we make before we cut a new release.

Describe alternatives you've considered:

None. This needs to happen.

@Tjzabel Tjzabel added the improvement Improves on something that already exists label Oct 15, 2020
@Tjzabel Tjzabel added the research Research and more data is needed to make a decision label Oct 25, 2020
@jwflory
Copy link
Member

jwflory commented Oct 25, 2020

Discussed in 2020-10-25 meeting.


We discussed a short-term way to solve this, which @Zedjones is working on for this ticket. We also discussed a long-term way to solve this.

Short-term

Create an executable script to create a TeleIRC release and inject a build-time variable for the TeleIRC release, determined by the latest git tag on TeleIRC. To obtain the release variable, we can use this command in the script:

git tag -l | tail -n 1

Long-term

Use GitHub Actions and GitHub Packages to publish the release. Ideally, this uses some of the heavy-lifting automation steps discussed in #343. It would be great to leverage an automated pipeline with a simple interface, instead of a long list of steps that an individual developer must remember and complete in the right order.

@jwflory jwflory added this to the v2.1.0 milestone Oct 25, 2020
jwflory pushed a commit that referenced this issue Oct 26, 2020
)

* Initial build script kinda done

* Initial build script actually done
@jwflory
Copy link
Member

jwflory commented Oct 26, 2020

Fixed in #352 by @Zedjones.

Long-term discussion will continue in #343 as part of release planning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves on something that already exists research Research and more data is needed to make a decision
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants