From 887127ee0b3d757eb22f6fc3193ebdc2930f85b7 Mon Sep 17 00:00:00 2001 From: Isaac Marovitz Date: Sun, 1 Sep 2024 21:09:56 +0200 Subject: [PATCH 1/3] Update workflows --- .github/workflows/format.yml | 4 ++-- .github/workflows/lint.yml | 6 +++--- .github/workflows/rpcsx.yml | 4 ++-- .github/workflows/tidy-comments.yml | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/format.yml b/.github/workflows/format.yml index 293d639d..817dc3c6 100644 --- a/.github/workflows/format.yml +++ b/.github/workflows/format.yml @@ -18,10 +18,10 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Run clang-format - uses: jidicula/clang-format-action@v4.11.0 + uses: jidicula/clang-format-action@v4.13.0 with: exclude-regex: (libspirv|3rdparty) clang-format-version: 16 diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 6b1ead74..ee8c0f93 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -7,11 +7,11 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out repo - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: submodules: recursive - name: Run clang-tidy - uses: ZedThree/clang-tidy-review@v0.14.0 + uses: ZedThree/clang-tidy-review@v0.19.0 id: review with: clang_tidy_version: 16 @@ -19,5 +19,5 @@ jobs: cmake_command: cmake . -DCMAKE_EXPORT_COMPILE_COMMANDS=on split_workflow: true - name: Upload review - uses: ZedThree/clang-tidy-review/upload@v0.14.0 + uses: ZedThree/clang-tidy-review/upload@v0.19.0 id: upload-review diff --git a/.github/workflows/rpcsx.yml b/.github/workflows/rpcsx.yml index 1bc705c3..4fcd2d9c 100644 --- a/.github/workflows/rpcsx.yml +++ b/.github/workflows/rpcsx.yml @@ -17,7 +17,7 @@ jobs: steps: - name: Checkout - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: submodules: recursive @@ -42,7 +42,7 @@ jobs: cmake --build build -j4 - name: Upload RPCSX - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: rpcsx-bin path: build/bin/* diff --git a/.github/workflows/tidy-comments.yml b/.github/workflows/tidy-comments.yml index 45e69dbc..f76ae001 100644 --- a/.github/workflows/tidy-comments.yml +++ b/.github/workflows/tidy-comments.yml @@ -8,6 +8,6 @@ jobs: build: runs-on: ubuntu-latest steps: - - uses: ZedThree/clang-tidy-review/post@v0.12.0 + - uses: ZedThree/clang-tidy-review/post@v0.19.0 with: lgtm_comment_body: "No linting issues found!" \ No newline at end of file From 198b20cc707e616e059d9763919b9c2a7f2f1b19 Mon Sep 17 00:00:00 2001 From: Isaac Marovitz Date: Sun, 1 Sep 2024 21:14:04 +0200 Subject: [PATCH 2/3] Clang format 18 --- .github/workflows/format.yml | 2 +- .github/workflows/lint.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/format.yml b/.github/workflows/format.yml index 817dc3c6..07689d24 100644 --- a/.github/workflows/format.yml +++ b/.github/workflows/format.yml @@ -24,4 +24,4 @@ jobs: uses: jidicula/clang-format-action@v4.13.0 with: exclude-regex: (libspirv|3rdparty) - clang-format-version: 16 + clang-format-version: 18 diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index ee8c0f93..9321beb1 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -14,7 +14,7 @@ jobs: uses: ZedThree/clang-tidy-review@v0.19.0 id: review with: - clang_tidy_version: 16 + clang_tidy_version: 18 apt_packages: libunwind-dev, libglfw3-dev, libvulkan-dev, vulkan-validationlayers-dev, spirv-tools, glslang-tools, libspirv-cross-c-shared-dev cmake_command: cmake . -DCMAKE_EXPORT_COMPILE_COMMANDS=on split_workflow: true From 8db0ed0b08ebe372a698aefd17333dbe10a90a03 Mon Sep 17 00:00:00 2001 From: Isaac Marovitz Date: Sun, 1 Sep 2024 21:20:56 +0200 Subject: [PATCH 3/3] Fix apt package --- .github/workflows/lint.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 9321beb1..03658ab8 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -15,7 +15,7 @@ jobs: id: review with: clang_tidy_version: 18 - apt_packages: libunwind-dev, libglfw3-dev, libvulkan-dev, vulkan-validationlayers-dev, spirv-tools, glslang-tools, libspirv-cross-c-shared-dev + apt_packages: libunwind-dev, libglfw3-dev, libvulkan-dev, vulkan-validationlayers, spirv-tools, glslang-tools, libspirv-cross-c-shared-dev cmake_command: cmake . -DCMAKE_EXPORT_COMPILE_COMMANDS=on split_workflow: true - name: Upload review