Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

entryID should not be a field on Video Object #4

Open
flipmcf opened this issue Feb 11, 2022 · 0 comments
Open

entryID should not be a field on Video Object #4

flipmcf opened this issue Feb 11, 2022 · 0 comments

Comments

@flipmcf
Copy link
Member

flipmcf commented Feb 11, 2022

The canonical way to get the entry id should be 'object.entryId'

The 'backend' way to get the entry id should be 'object.KalturaObject.getId()' - but this shouldn't be used under normal circumstances.

object.entryId getter (dexterity) needs to be created and used, and should under most circumstances, simply call 'object.KalturaObject.getId()' and handle all exceptions that may occur due to that call.

This was the behavior in rfa.kaltura in Archetypes.
https://github.com/RadioFreeAsia/rfa.kaltura/blob/9eb2a48178280bafbb1c2c665bd74ab14f99ceb6/rfa/kaltura/content/base.py#L12
https://github.com/RadioFreeAsia/rfa.kaltura/blob/9eb2a48178280bafbb1c2c665bd74ab14f99ceb6/rfa/kaltura/content/base.py#L108

This caused a bug that was just fixed by this commit:
3b87589

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant