Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better looking buffering animation (e.g. AdwSpinner) #480

Open
heldderarbeit opened this issue Aug 10, 2024 · 5 comments
Open

Better looking buffering animation (e.g. AdwSpinner) #480

heldderarbeit opened this issue Aug 10, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@heldderarbeit
Copy link

When loading a video from a url, clapper currently shows three white dots to show the buffering of new content.

Screenshot from 2024-08-10 21-44-31

Screenshot from 2024-08-10 21-47-36

I find these buttons jarring and feel they don't fit the modern style of the rest of the application, especially juxtaposed against the image beneath them.

Since Version 1.6, Libadwaita has now a new spinner widget named AdwSpinner which maybe can used instead:

https://thisweek.gnome.org/posts/2024/07/twig-156/4067bdc35fe1bf7af97eadc464f9b52cfcd8e46b1811437392997908480.mp4
https://gnome.pages.gitlab.gnome.org/libadwaita/doc/main/class.Spinner.html

@Rafostar Rafostar added the enhancement New feature or request label Aug 10, 2024
@Rafostar
Copy link
Owner

Rafostar commented Aug 10, 2024

NOTE: requires libadwaita 1.6

We cannot use libadwaita widgets in ClapperGtk lib in which current buffering animation is. Video widget must depend on GTK only. The existing animation can always be changed/improved through.

@Rafostar Rafostar changed the title Replace white dots animation for buffering with AdwSpinner Better looking buffering animation (e.g. AdwSpinner) Aug 11, 2024
@lo2dev
Copy link

lo2dev commented Nov 15, 2024

Just throwing out an idea, not sure how feasible it is, but maybe ClapperGtk could expose a signal when loading/buffering so apps can connect to it to display a widget of their choosing (AdwSpinner).

@Rafostar
Copy link
Owner

Rafostar commented Nov 15, 2024

Just throwing out an idea, not sure how feasible it is, but maybe ClapperGtk could expose a signal when loading/buffering so apps can connect to it to display a widget of their choosing (AdwSpinner).

Since buffering paintable is part of the ClapperGtkVideo widget. It would have to be removed from it, so this solution is do-able, but a Clapper 1.0 material.

Why is the spinner not part of GTK, but libadwaita anyway? 🤔

@lo2dev
Copy link

lo2dev commented Nov 15, 2024

Why is the spinner not part of GTK, but libadwaita anyway? 🤔

My guess is that the new spinner is part of the gnome/libadwaita design and GTK is trying to stay a neutral toolkit

@sp1ritCS
Copy link
Contributor

Doesn't Adwaita also re-style the GtkSpinner to look more GNOMEy? (but that spinner is a lot smaller than the new one)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants