Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up timeouts #164

Closed
RagnarGrootKoerkamp opened this issue Nov 12, 2021 · 2 comments
Closed

Clean up timeouts #164

RagnarGrootKoerkamp opened this issue Nov 12, 2021 · 2 comments

Comments

@RagnarGrootKoerkamp
Copy link
Owner

  • There is the global program timeout for generators/visualizers/building (i.e.anything not submissions), which defaults to 30s and is overridden by --timeout for e.g. bt generate
  • There is a per problem submission timeout, which is derived from the timelimit and overridden using --timeout on bt run.

This makes for some inconsistency because now timeout is both a program and problem property.

We could 'fix' the code and always make timeout a program property, which is either derived from the global timeout or from the problem timeout, but I'm not sure that's actually worth fixing.

I think we should fix the duplicate --timeout flag name, since this makes bapctools.yaml configuration a bit annoying otherwise. I'm not exactly sure how though. One option is to give a different name to one of them, but have -T as shortcut for both anyway. (-t is currently the shortcut for timelimit already.)

@mpsijm
Copy link
Collaborator

mpsijm commented Nov 12, 2021

(duplicate of #165)

@RagnarGrootKoerkamp
Copy link
Owner Author

Whoops; hitting ctrl-enter instead of enter twice does this. #blamegithub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants