Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public IP Changing Doesn't Update #38

Open
necromancyr opened this issue Apr 21, 2021 · 1 comment
Open

Public IP Changing Doesn't Update #38

necromancyr opened this issue Apr 21, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@necromancyr
Copy link

This is going to be a difficult one to test around I think, but it looks like the external IP is checked on VSW start and then not updated/rechecked each time the server is updated. This only impacts the Discord announcement and connection string feature, so it's not a major issue, but could be resolved with an external IP check prior to server start (if it's not already).

@Razzmatazzz
Copy link
Owner

That is correct; VSW only checks the public IP when the app is started and then assumes that it doesn't change. It's my understanding that one's public IP isn't likely to change frequently, so I figured this shouldn't be much of an issue.

@Razzmatazzz Razzmatazzz added the enhancement New feature or request label Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants