Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make meet your host section dynamic #232

Closed
wants to merge 8 commits into from
Closed

make meet your host section dynamic #232

wants to merge 8 commits into from

Conversation

Konzisam
Copy link
Collaborator

image
we can now get the data dynamically in the meet ypur host section

CHANGES
Meet your host Right:

  • only render super host sections when a user is a superhost
  • change meetyourhost section to receive props and drill the stat to its child components.
  • add a json in product page as placeholder as there is no meetyourhost specific data in json file

@Konzisam Konzisam linked an issue Oct 24, 2024 that may be closed by this pull request
make meetYourHost dynamic #235
Open
grabinskij
grabinskij requested changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@grabinskij grabinskij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Samuel, in the MeetYourHostSection instead of rating={place.reviewSummary.valueAvgRating} it should be rating={place.reviewSummary.totalAvgRating},otherwise average rating are not shown in the component.

@Konzisam
Copy link
Collaborator Author

closed this without merging it seems tthere is a branch with the same changes already

@Konzisam Konzisam closed this Nov 14, 2024
@Konzisam
Copy link
Collaborator Author

Unnecessary to merge, the changes are already in the reflected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grabinskij grabinskij grabinskij requested changes

@BajalanIman BajalanIman Awaiting requested review from BajalanIman

@alinaincodeland alinaincodeland Awaiting requested review from alinaincodeland

@matus-vacula matus-vacula Awaiting requested review from matus-vacula

@orYoffe orYoffe Awaiting requested review from orYoffe

@xaved88 xaved88 Awaiting requested review from xaved88

@awalmubarak awalmubarak Awaiting requested review from awalmubarak

@GabrielMelhem GabrielMelhem Awaiting requested review from GabrielMelhem

@miklesch miklesch Awaiting requested review from miklesch

@messkalina messkalina Awaiting requested review from messkalina

@BabakBani-ReDI-DCP-HH BabakBani-ReDI-DCP-HH Awaiting requested review from BabakBani-ReDI-DCP-HH

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make meetYourHost dynamic
2 participants
@Konzisam @grabinskij