-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TP/Jobseeker Profile & Company Profile:] Align the design of the close icon in modals on CON and TP #388
Comments
@miriam-aha I updated this ticket according to our discussion here. The design input is needed to proceed. |
@katamatata As just mentioned, I added the link to the designs that Rita provided incl. her explanation. Will you pick up the ticket and implement these designs? 😃 |
As discussed with the design team, I put back the |
According to @ligiamxm , the UX/UI activities are done. |
@ligiamxm, have we discussed the mobile version already? |
@katamatata and @ericbolikowski can you add some notes about what's the most recent status for this task? We can close it if it's not in scope anymore. |
@helloanil, it has not been implemented yet and is ready. |
Anil's estimation of this ticket: 2-4 hours. |
Context/background
Currently, the design and the position of the close icon in modals on CON and TP look different. We want to have a unified design for this icon on both platforms.
What needs to be done?
In all modals on CON and TP:
In all modals on TP:
UI/UX design assets / specification
Please see current designs by Rita and Lígia here.
Some guiding info to accompany the designs:
Acessibility
For the hover state, we should never use light colors like the one from the connect website
Colors for action usage
In order to ensure a consistent user experience through the website, we need to consider the color that is used in other hover states (like in buttons, for example)
Clickable are around the button
The clickable space around a button (padding) is very important, specially in a dialog. If the space is too big, the user can easily click without that intention. In the other hand, if it's too small, the user can get frustrated for not being able to click on it. The best pratice is to use multiples of 8px around it 🙂
Background color
A background color is normally more used in cases where a button has an outlined already, which is not this case. I would say that adding the background is more likely to pollute visually than helping.
In a dialog, the close button needs to be always inside the container 🙂
So, overall, I believe we should stick to the close icon itself using:
$black
when default$redi-orange
when hovered$red
when clicked (need to verify with you the use cases for red)$redi-orange-extra-light
when disabledThe text was updated successfully, but these errors were encountered: