Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TP/Jobseeker Profile & Company Profile:] Align the design of the close icon in modals on CON and TP #388

Open
1 of 3 tasks
katamatata opened this issue Jul 1, 2021 · 9 comments
Labels
Area/frontend [react] in the client side application Bug report Something isn't working

Comments

@katamatata
Copy link
Contributor

katamatata commented Jul 1, 2021

Context/background

Currently, the design and the position of the close icon in modals on CON and TP look different. We want to have a unified design for this icon on both platforms.

What needs to be done?

In all modals on CON and TP:

  • Define UI for a close icon in modals: size, color, form, :hover effect
  • Align the design of the close icon on CON and TP

In all modals on TP:

  • Replicate how the close icon is used from CON to TP: inside the popup, at the right top corner

UI/UX design assets / specification

Please see current designs by Rita and Lígia here.

Some guiding info to accompany the designs:

  1. Acessibility
    For the hover state, we should never use light colors like the one from the connect website

  2. Colors for action usage
    In order to ensure a consistent user experience through the website, we need to consider the color that is used in other hover states (like in buttons, for example)

  3. Clickable are around the button
    The clickable space around a button (padding) is very important, specially in a dialog. If the space is too big, the user can easily click without that intention. In the other hand, if it's too small, the user can get frustrated for not being able to click on it. The best pratice is to use multiples of 8px around it 🙂

  4. Background color
    A background color is normally more used in cases where a button has an outlined already, which is not this case. I would say that adding the background is more likely to pollute visually than helping.

  5. In a dialog, the close button needs to be always inside the container 🙂
    So, overall, I believe we should stick to the close icon itself using:

$black when default
$redi-orange when hovered
$red when clicked (need to verify with you the use cases for red)
$redi-orange-extra-light when disabled

@katamatata katamatata added Bug report Something isn't working Area/frontend [react] in the client side application Task labels Jul 1, 2021
@miriam-aha miriam-aha changed the title [Talent Pool/Jobseeker Profile/Company Profile:] Change the color of the hovered close icon in modals [Jobseeker Profile & Company Profile:] Change the color of the hovered close icon in modals Aug 27, 2021
@miriam-aha miriam-aha changed the title [Jobseeker Profile & Company Profile:] Change the color of the hovered close icon in modals [TP/Jobseeker Profile & Company Profile:] Change the color of the hovered close icon in modals Aug 31, 2021
@katamatata katamatata self-assigned this Feb 14, 2022
@katamatata katamatata changed the title [TP/Jobseeker Profile & Company Profile:] Change the color of the hovered close icon in modals [TP/Jobseeker Profile & Company Profile:] Align the design of the close icon in modals on CON and TP Mar 11, 2022
@katamatata
Copy link
Contributor Author

katamatata commented Mar 11, 2022

@miriam-aha I updated this ticket according to our discussion here. The design input is needed to proceed.

@miriam-aha
Copy link
Contributor

@katamatata As just mentioned, I added the link to the designs that Rita provided incl. her explanation. Will you pick up the ticket and implement these designs? 😃

@katamatata
Copy link
Contributor Author

katamatata commented Oct 5, 2022

As discussed with the design team, I put back the Build UX/UI label because first, we want to define and align design specifications (accessibility, clickableness, color effects) for icons in the design system to have consistency throughout our different components and user experiences.

@ligiamxm ligiamxm self-assigned this Dec 21, 2022
@fortini
Copy link

fortini commented Apr 25, 2023

According to @ligiamxm , the UX/UI activities are done.
From the dev side, is there something missing, @katamatata

@katamatata
Copy link
Contributor Author

@ligiamxm, have we discussed the mobile version already?

@helloanil
Copy link
Contributor

@katamatata and @ericbolikowski can you add some notes about what's the most recent status for this task? We can close it if it's not in scope anymore.

@katamatata
Copy link
Contributor Author

@helloanil, it has not been implemented yet and is ready.

@astkhikatredi
Copy link
Contributor

astkhikatredi commented Mar 28, 2024

This ticket could be done together with #906 and #904

@astkhikatredi
Copy link
Contributor

Anil's estimation of this ticket: 2-4 hours.

@astkhikatredi astkhikatredi removed the Priority: High This ticket has a high priority label Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area/frontend [react] in the client side application Bug report Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

7 participants