Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Select bundle type, before entering the screen to add it #1250

Closed
oSumAtrIX opened this issue Sep 7, 2023 · 2 comments · Fixed by #1490
Closed

feat: Select bundle type, before entering the screen to add it #1250

oSumAtrIX opened this issue Sep 7, 2023 · 2 comments · Fixed by #1490
Assignees
Labels
ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager

Comments

@oSumAtrIX
Copy link
Member

oSumAtrIX commented Sep 7, 2023

Before you enter the screen to import a patch bundle, let the user first choose if they want to import a remote or local bundle:

image

UX-wise it makes no sense to put the bundle type here as a button. Either a dropdown or a switch should be used. At best the user should first decide if they want a local or remote bundle, then enter this screen. This simplifies the screen and gets rid of the confusing UX of switching between bundle types changing the entire screens content.

The bundle type option also exists after adding the bundle. For the same reason, this should also be removed here. If the user wants to change the type, they intend to add a completely new bundle to begin with. There is no purpose in having this setting after adding the bundle.

@oSumAtrIX oSumAtrIX added the ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager label Sep 7, 2023
@Axelen123
Copy link
Member

Needs to be changed in the figma

@Ushie
Copy link
Member

Ushie commented Nov 7, 2023

I can pick this up after #1464, #1465 and #1467, with this design from Figma:
image

@Ushie Ushie self-assigned this Nov 7, 2023
@Ushie Ushie linked a pull request Nov 13, 2023 that will close this issue
1 task
@Ushie Ushie closed this as completed Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants