Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: YouTube patch failure #3547

Closed
3 tasks done
MrCreepyCraft32 opened this issue Aug 15, 2024 · 14 comments · Fixed by #3551
Closed
3 tasks done

bug: YouTube patch failure #3547

MrCreepyCraft32 opened this issue Aug 15, 2024 · 14 comments · Fixed by #3551
Labels
Bug report Something isn't working

Comments

@MrCreepyCraft32
Copy link

Bug description

Running on Manager 1.21.2 with patches 4.13.2 when patching YouTube APK version 19.16.39

Error logs

- Device Info
ReVanced Manager: 1.21.2
Model: SM-S916B
Android version: 14
Supported architectures: arm64-v8a, armeabi-v7a, armeabi
Root permissions: No

- Patch Info
App: com.google.android.youtube v19.16.39 (Suggested: 19.16.39)
Patches version: v4.13.2
Patches added: Change header [Header: premium*header]
Patches removed: None
Default patch options changed: None

- Settings
Allow changing patch selection: true
Version compatibility check: true
Show universal patches: false
Patches source: revanced/revanced-patches
Integration source: revanced/revanced-integrations

- Logs
Reading APK
Decoding app manifest
Loading patches
Merging integrations
Deleting existing temporary files directory
Decoding resources
Executing patches
Applied 61 patches
Compiling patched dex files
Compiled 8 dex files
Compiling modified resources
An error occurred:
brut.androlib.exceptions.AndrolibException: brut.common.BrutException: could not exec (exit code = 1): [/data/app/~~5ROKNGiZFQgmfHzhMdhVmg==/app.revanced.manager.flutter-nIoGgg25g7hRmMwGBYWYSw==/lib/arm64/libaapt2.so, compile, --dir, /data/user/0/app.revanced.manager.flutter/cache/patcher/tmp-FUZWCT/revanced-temporary-files/apk/res, --legacy, -o, /data/user/0/app.revanced.manager.flutter/cache/patcher/tmp-FUZWCT/revanced-temporary-files/apk/build/resources.zip]
	at brut.androlib.AaptInvoker.invokeAapt2(Unknown Source:144)
	at brut.androlib.AaptInvoker.invokeAapt(Unknown Source:106)
	at app.revanced.patcher.data.ResourceContext.get(SourceFile:0)
	at app.revanced.patcher.Patcher.get(SourceFile:0)
	at app.revanced.manager.flutter.MainActivity.runPatcher$lambda$35(Unknown Source:462)
	at app.revanced.manager.flutter.MainActivity.$r8$lambda$t9VOe3aFJZkCMY59Ya4Pcinu-pA(SourceFile:0)
	at app.revanced.manager.flutter.MainActivity$$ExternalSyntheticLambda6.run(SourceFile:0)
	at java.lang.Thread.run(Thread.java:1012)
Caused by: brut.common.BrutException: could not exec (exit code = 1): [/data/app/~~5ROKNGiZFQgmfHzhMdhVmg==/app.revanced.manager.flutter-nIoGgg25g7hRmMwGBYWYSw==/lib/arm64/libaapt2.so, compile, --dir, /data/user/0/app.revanced.manager.flutter/cache/patcher/tmp-FUZWCT/revanced-temporary-files/apk/res, --legacy, -o, /data/user/0/app.revanced.manager.flutter/cache/patcher/tmp-FUZWCT/revanced-temporary-files/apk/build/resources.zip]
	at brut.util.OS.exec(Unknown Source:75)
	at brut.androlib.AaptInvoker.invokeAapt2(Unknown Source:122)
	... 7 more
Something went wrong:
PathNotFoundException: Cannot copy file to '/data/user/0/app.revanced.manager.flutter/files/lastPatchedApp.apk', path = '/data/user/0/app.revanced.manager.flutter/cache/patcher/tmp-FUZWCT/out.apk' (OS Error: No such file or directory, errno = 2)

Solution

No response

Additional context

No response

Acknowledgements

  • I have checked all open and closed bug reports and this is not a duplicate.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@MrCreepyCraft32 MrCreepyCraft32 added the Bug report Something isn't working label Aug 15, 2024
@MrCreepyCraft32 MrCreepyCraft32 changed the title YouTube patch failure bug: YouTube patch failure Aug 15, 2024
@MarcaDian
Copy link
Contributor

MarcaDian commented Aug 15, 2024

@MrCreepyCraft32
Copy link
Author

ReVanced/revanced-manager#2125

Sorry, I thought it was related to the recent patches updates

@Sunsper

This comment was marked as duplicate.

@MrCreepyCraft32
Copy link
Author

ReVanced/revanced-manager#2125

I'm using the latest version of the Manager and I have this issue with AND without the "Save last APK" option enabled
I guess that fix didn't work, or I did something wrong...

@MarcaDian
Copy link
Contributor

ReVanced Manager Compose give that log, maybe it will be useful

[INFO]: Merging integrations
[INFO]: Applying patches...
[INFO]: Merging integrations
[INFO]: Deleting existing temporary files directory
[INFO]: Decoding resources
[INFO]: Loading resource table...
[INFO]: Decoding file-resources...
[INFO]: Loading resource table from file: /data/user/0/app.revanced.manager.debug/cache/framework/1.apk
[INFO]: Decoding values */* XMLs...
[INFO]: Decoding AndroidManifest.xml with resources...
[INFO]: Regular manifest package...
[INFO]: Executing patches
[INFO]: Alternative thumbnails succeeded
[INFO]: Always repeat succeeded
[INFO]: Announcements succeeded
[INFO]: Bypass URL redirects succeeded
[INFO]: Bypass image region restrictions succeeded
[INFO]: Change start page succeeded
[INFO]: Check watch history domain name resolution succeeded
[INFO]: Comments succeeded
[INFO]: Copy video URL succeeded
[INFO]: Custom player overlay opacity succeeded
[INFO]: Disable auto captions succeeded
[INFO]: Disable fullscreen ambient mode succeeded
[INFO]: Disable player popup panels succeeded
[INFO]: Disable precise seeking gesture succeeded
[INFO]: Disable resuming Shorts on startup succeeded
[INFO]: Disable rolling number animations succeeded
[INFO]: Disable suggested video end screen succeeded
[INFO]: Disable zoom haptics succeeded
[INFO]: Downloads succeeded
[INFO]: Enable debugging succeeded
[INFO]: Enable slide to seek succeeded
[INFO]: Enable tablet layout succeeded
[INFO]: GmsCore support succeeded
[INFO]: Hide Shorts components succeeded
[INFO]: Hide ads succeeded
[INFO]: Hide album cards succeeded
[INFO]: Hide autoplay button succeeded
[INFO]: Hide captions button succeeded
[INFO]: Hide cast button succeeded
[INFO]: Hide crowdfunding box succeeded
[INFO]: Hide endscreen cards succeeded
[INFO]: Hide filter bar succeeded
[INFO]: Hide floating microphone button succeeded
[INFO]: Hide info cards succeeded
[INFO]: Hide layout components succeeded
[INFO]: Hide player buttons succeeded
[INFO]: Hide seekbar succeeded
[INFO]: Hide timestamp succeeded
[INFO]: Hide video action buttons succeeded
[INFO]: Miniplayer succeeded
[INFO]: Navigation buttons succeeded
[INFO]: Open links externally succeeded
[INFO]: Playback speed succeeded
[INFO]: Player flyout menu succeeded
[INFO]: Remember video quality succeeded
[INFO]: Remove background playback restrictions succeeded
[INFO]: Remove tracking query parameter succeeded
[INFO]: Remove viewer discretion dialog succeeded
[INFO]: Restore old seekbar thumbnails succeeded
[INFO]: Restore old video quality menu succeeded
[INFO]: Return YouTube Dislike succeeded
[INFO]: Seekbar tapping succeeded
[INFO]: SponsorBlock succeeded
[INFO]: Spoof app version succeeded
[INFO]: Spoof client succeeded
[INFO]: Spoof device dimensions succeeded
[INFO]: Swipe controls succeeded
[INFO]: Theme succeeded
[INFO]: Video ads succeeded
[INFO]: Wide searchbar succeeded
[INFO]: Writing patched files...
[INFO]: Compiling patched dex files
[INFO]: Compiled classes.dex
[INFO]: Compiled classes2.dex
[INFO]: Compiled classes3.dex
[INFO]: Compiled classes4.dex
[INFO]: Compiled classes5.dex
[INFO]: Compiled classes6.dex
[INFO]: Compiled classes7.dex
[INFO]: Compiled classes8.dex
[INFO]: Compiling modified resources
[WARN]: /data/user/0/app.revanced.manager.debug/cache/ephemeral/patcher/apk/res/values-de/strings.xml:0: error: xml parser error: reference to invalid character number.
[WARN]: /data/user/0/app.revanced.manager.debug/cache/ephemeral/patcher/apk/res/values-de/strings.xml: error: file failed to compile.

@LisoUseInAIKyrios
Copy link
Contributor

The issue appears to be something with one of the German translations.

This issue does not show up when patching using cli.

@toleranta

This comment was marked as spam.

@MrKaon

This comment was marked as spam.

@LisoUseInAIKyrios
Copy link
Contributor

The issue is a string in SponsorBlock. If excluded it patches correctly.

@LisoUseInAIKyrios
Copy link
Contributor

LisoUseInAIKyrios commented Aug 15, 2024

It appears to be caused by an emoji in a german translation:

SponsorBlock vorübergehend nicht verfügbar (API 🕛 out)

edit: Marca beat me to it

@webzeroacs
Copy link

webzeroacs commented Aug 15, 2024

Using the CLI, the patch works as usually on Windows. the apk was also installed well, so there is no problem to use.

@LisoUseInAIKyrios LisoUseInAIKyrios linked a pull request Aug 15, 2024 that will close this issue
1 task
@MrCreepyCraft32
Copy link
Author

Using the CLI, the patch works as usually on Windows. the apk was also installed well, so there is no problem to use.

Yes, it's apparently an issue with the manager
I originally thought it was related to the patches but it's not

@LisoUseInAIKyrios
Copy link
Contributor

The issue is fixed, patching with Manager works again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants