You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 7, 2024. It is now read-only.
One difference we've found between the RMG-Java and RMG-Py group additivity thermo estimates is that RMG-Java does not appear to apply corrections from the "other" groups, while RMG-Py does. An example is 1,2-dimethylbenzene, for which RMG-Py adds two corrections for "ortho" groups. (Depending on how the correction values were determined, this could be an incorrect double-counting, but that's a separate question.) Looking at the code, it seems this has been the case since at least February of 2009, and probably before that.
The "other" groups currently contains corrections for cis double bonds, ketenes, and the ortho group.
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
One difference we've found between the RMG-Java and RMG-Py group additivity thermo estimates is that RMG-Java does not appear to apply corrections from the "other" groups, while RMG-Py does. An example is 1,2-dimethylbenzene, for which RMG-Py adds two corrections for "ortho" groups. (Depending on how the correction values were determined, this could be an incorrect double-counting, but that's a separate question.) Looking at the code, it seems this has been the case since at least February of 2009, and probably before that.
The "other" groups currently contains corrections for cis double bonds, ketenes, and the ortho group.
The text was updated successfully, but these errors were encountered: