From 494ddebd87e82ce7b05de3cb7ce549d6d09b4abf Mon Sep 17 00:00:00 2001 From: Wagner Trezub Date: Mon, 27 Jan 2025 12:40:04 +0100 Subject: [PATCH 01/20] fix: skiplinks --- src/components/ItaliaTheme/SkipLinks/SkipLinks.jsx | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/components/ItaliaTheme/SkipLinks/SkipLinks.jsx b/src/components/ItaliaTheme/SkipLinks/SkipLinks.jsx index c2f247fa6..049ec2d52 100644 --- a/src/components/ItaliaTheme/SkipLinks/SkipLinks.jsx +++ b/src/components/ItaliaTheme/SkipLinks/SkipLinks.jsx @@ -15,6 +15,10 @@ const messages = defineMessages({ id: 'skiplink-footer', defaultMessage: 'Skip to footer', }, + skiplinks_description: { + id: 'skiplinks-description', + defaultMessage: 'Skiplinks', + }, }); const SkipLinks = () => { @@ -32,7 +36,11 @@ const SkipLinks = () => { return (
- + {intl.formatMessage(messages.mainView)} From 685d70b41b70248e48b503eac0fcf2b70669ae04 Mon Sep 17 00:00:00 2001 From: Wagner Trezub Date: Mon, 27 Jan 2025 15:19:30 +0100 Subject: [PATCH 02/20] fix: removed role and aria label for carousel --- .../ItaliaTheme/Slider/CarouselWrapper.jsx | 19 +------------------ 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/src/components/ItaliaTheme/Slider/CarouselWrapper.jsx b/src/components/ItaliaTheme/Slider/CarouselWrapper.jsx index 3f4122d88..64b9b2bcc 100644 --- a/src/components/ItaliaTheme/Slider/CarouselWrapper.jsx +++ b/src/components/ItaliaTheme/Slider/CarouselWrapper.jsx @@ -1,23 +1,6 @@ import React from 'react'; -import { defineMessages, useIntl } from 'react-intl'; -const messages = defineMessages({ - carousel: { - id: 'carousel', - defaultMessage: 'Carosello', - }, -}); const CarouselWrapper = ({ className, children }) => { - const intl = useIntl(); - - return ( -
- {children} -
- ); + return
{children}
; }; export default CarouselWrapper; From 00bde5217ffa7bd27ab98091e53a8b1d709f75d9 Mon Sep 17 00:00:00 2001 From: Wagner Trezub Date: Mon, 27 Jan 2025 15:43:35 +0100 Subject: [PATCH 03/20] fix: undo carousel changes --- .../ItaliaTheme/Slider/CarouselWrapper.jsx | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/src/components/ItaliaTheme/Slider/CarouselWrapper.jsx b/src/components/ItaliaTheme/Slider/CarouselWrapper.jsx index 64b9b2bcc..3f4122d88 100644 --- a/src/components/ItaliaTheme/Slider/CarouselWrapper.jsx +++ b/src/components/ItaliaTheme/Slider/CarouselWrapper.jsx @@ -1,6 +1,23 @@ import React from 'react'; +import { defineMessages, useIntl } from 'react-intl'; +const messages = defineMessages({ + carousel: { + id: 'carousel', + defaultMessage: 'Carosello', + }, +}); const CarouselWrapper = ({ className, children }) => { - return
{children}
; + const intl = useIntl(); + + return ( +
+ {children} +
+ ); }; export default CarouselWrapper; From f66ce58b545bbd1cddd8b1c030840117f1d87cd8 Mon Sep 17 00:00:00 2001 From: Wagner Trezub Date: Tue, 28 Jan 2025 09:17:47 +0100 Subject: [PATCH 04/20] fix: aria-label and role for FeedbackForm and ParentSiteMenu --- locales/de/LC_MESSAGES/volto.po | 15 +++++++++++++++ locales/en/LC_MESSAGES/volto.po | 15 +++++++++++++++ locales/es/LC_MESSAGES/volto.po | 15 +++++++++++++++ locales/fr/LC_MESSAGES/volto.po | 15 +++++++++++++++ locales/it/LC_MESSAGES/volto.po | 15 +++++++++++++++ locales/volto.pot | 17 ++++++++++++++++- .../CustomerSatisfaction/FeedbackForm.jsx | 10 +++++++++- .../ItaliaTheme/Header/ParentSiteMenu.jsx | 15 ++++++++++++++- 8 files changed, 114 insertions(+), 3 deletions(-) diff --git a/locales/de/LC_MESSAGES/volto.po b/locales/de/LC_MESSAGES/volto.po index 9c063a47f..82fb5fbdb 100644 --- a/locales/de/LC_MESSAGES/volto.po +++ b/locales/de/LC_MESSAGES/volto.po @@ -2187,6 +2187,11 @@ msgstr "" msgid "feedback_error" msgstr "" +#: components/ItaliaTheme/CustomerSatisfaction/FeedbackForm +# defaultMessage: Feedback form +msgid "feedback_form_aria_title" +msgstr "" + #: components/ItaliaTheme/CustomerSatisfaction/FeedbackForm # defaultMessage: Next msgid "feedback_form_button_next" @@ -2987,6 +2992,11 @@ msgstr "" msgid "paginationLabel" msgstr "" +#: components/ItaliaTheme/Header/ParentSiteMenu +# defaultMessage: Main site menu +msgid "parent_site_menu" +msgstr "" + #: components/ItaliaTheme/View/EventoView/EventoCosE # defaultMessage: Parteciperanno msgid "parteciperanno" @@ -3908,6 +3918,11 @@ msgstr "" msgid "skiplink-navigation" msgstr "" +#: components/ItaliaTheme/SkipLinks/SkipLinks +# defaultMessage: Skiplinks +msgid "skiplinks-description" +msgstr "" + #: components/ItaliaTheme/View/PuntoDiContattoView/PuntoDiContattoView #: helpers/contentHelper # defaultMessage: Skype diff --git a/locales/en/LC_MESSAGES/volto.po b/locales/en/LC_MESSAGES/volto.po index d4eb2cd49..6d1982f3d 100644 --- a/locales/en/LC_MESSAGES/volto.po +++ b/locales/en/LC_MESSAGES/volto.po @@ -2172,6 +2172,11 @@ msgstr "" msgid "feedback_error" msgstr "" +#: components/ItaliaTheme/CustomerSatisfaction/FeedbackForm +# defaultMessage: Feedback form +msgid "feedback_form_aria_title" +msgstr "" + #: components/ItaliaTheme/CustomerSatisfaction/FeedbackForm # defaultMessage: Next msgid "feedback_form_button_next" @@ -2972,6 +2977,11 @@ msgstr "This page is managed by" msgid "paginationLabel" msgstr "Page selector" +#: components/ItaliaTheme/Header/ParentSiteMenu +# defaultMessage: Main site menu +msgid "parent_site_menu" +msgstr "" + #: components/ItaliaTheme/View/EventoView/EventoCosE # defaultMessage: Parteciperanno msgid "parteciperanno" @@ -3893,6 +3903,11 @@ msgstr "Go to content" msgid "skiplink-navigation" msgstr "Go to navigation" +#: components/ItaliaTheme/SkipLinks/SkipLinks +# defaultMessage: Skiplinks +msgid "skiplinks-description" +msgstr "" + #: components/ItaliaTheme/View/PuntoDiContattoView/PuntoDiContattoView #: helpers/contentHelper # defaultMessage: Skype diff --git a/locales/es/LC_MESSAGES/volto.po b/locales/es/LC_MESSAGES/volto.po index eaaec0ec5..e394f797c 100644 --- a/locales/es/LC_MESSAGES/volto.po +++ b/locales/es/LC_MESSAGES/volto.po @@ -2181,6 +2181,11 @@ msgstr "" msgid "feedback_error" msgstr "" +#: components/ItaliaTheme/CustomerSatisfaction/FeedbackForm +# defaultMessage: Feedback form +msgid "feedback_form_aria_title" +msgstr "" + #: components/ItaliaTheme/CustomerSatisfaction/FeedbackForm # defaultMessage: Next msgid "feedback_form_button_next" @@ -2981,6 +2986,11 @@ msgstr "Esta página es administrada por" msgid "paginationLabel" msgstr "" +#: components/ItaliaTheme/Header/ParentSiteMenu +# defaultMessage: Main site menu +msgid "parent_site_menu" +msgstr "" + #: components/ItaliaTheme/View/EventoView/EventoCosE # defaultMessage: Parteciperanno msgid "parteciperanno" @@ -3902,6 +3912,11 @@ msgstr "Ir al contenido" msgid "skiplink-navigation" msgstr "Ir a navegación" +#: components/ItaliaTheme/SkipLinks/SkipLinks +# defaultMessage: Skiplinks +msgid "skiplinks-description" +msgstr "" + #: components/ItaliaTheme/View/PuntoDiContattoView/PuntoDiContattoView #: helpers/contentHelper # defaultMessage: Skype diff --git a/locales/fr/LC_MESSAGES/volto.po b/locales/fr/LC_MESSAGES/volto.po index 7d3ae4bf2..2190c0a3f 100644 --- a/locales/fr/LC_MESSAGES/volto.po +++ b/locales/fr/LC_MESSAGES/volto.po @@ -2189,6 +2189,11 @@ msgstr "" msgid "feedback_error" msgstr "" +#: components/ItaliaTheme/CustomerSatisfaction/FeedbackForm +# defaultMessage: Feedback form +msgid "feedback_form_aria_title" +msgstr "" + #: components/ItaliaTheme/CustomerSatisfaction/FeedbackForm # defaultMessage: Next msgid "feedback_form_button_next" @@ -2989,6 +2994,11 @@ msgstr "Cette page est gérée par" msgid "paginationLabel" msgstr "" +#: components/ItaliaTheme/Header/ParentSiteMenu +# defaultMessage: Main site menu +msgid "parent_site_menu" +msgstr "" + #: components/ItaliaTheme/View/EventoView/EventoCosE # defaultMessage: Parteciperanno msgid "parteciperanno" @@ -3910,6 +3920,11 @@ msgstr "Aller au contenu" msgid "skiplink-navigation" msgstr "Aller à la navigation" +#: components/ItaliaTheme/SkipLinks/SkipLinks +# defaultMessage: Skiplinks +msgid "skiplinks-description" +msgstr "" + #: components/ItaliaTheme/View/PuntoDiContattoView/PuntoDiContattoView #: helpers/contentHelper # defaultMessage: Skype diff --git a/locales/it/LC_MESSAGES/volto.po b/locales/it/LC_MESSAGES/volto.po index 080a8d804..237646509 100644 --- a/locales/it/LC_MESSAGES/volto.po +++ b/locales/it/LC_MESSAGES/volto.po @@ -2172,6 +2172,11 @@ msgstr "Le indicazioni erano complete" msgid "feedback_error" msgstr "Errore" +#: components/ItaliaTheme/CustomerSatisfaction/FeedbackForm +# defaultMessage: Feedback form +msgid "feedback_form_aria_title" +msgstr "Modulo di soddisfazione del cliente" + #: components/ItaliaTheme/CustomerSatisfaction/FeedbackForm # defaultMessage: Next msgid "feedback_form_button_next" @@ -2972,6 +2977,11 @@ msgstr "Questa pagina è gestita da" msgid "paginationLabel" msgstr "Selettore di pagina" +#: components/ItaliaTheme/Header/ParentSiteMenu +# defaultMessage: Main site menu +msgid "parent_site_menu" +msgstr "Menu sito principale" + #: components/ItaliaTheme/View/EventoView/EventoCosE # defaultMessage: Parteciperanno msgid "parteciperanno" @@ -3893,6 +3903,11 @@ msgstr "Vai al contenuto" msgid "skiplink-navigation" msgstr "Vai alla navigazione" +#: components/ItaliaTheme/SkipLinks/SkipLinks +# defaultMessage: Skiplinks +msgid "skiplinks-description" +msgstr "" + #: components/ItaliaTheme/View/PuntoDiContattoView/PuntoDiContattoView #: helpers/contentHelper # defaultMessage: Skype diff --git a/locales/volto.pot b/locales/volto.pot index 03b1e7b25..dce0075ab 100644 --- a/locales/volto.pot +++ b/locales/volto.pot @@ -1,7 +1,7 @@ msgid "" msgstr "" "Project-Id-Version: Plone\n" -"POT-Creation-Date: 2025-01-22T15:35:43.837Z\n" +"POT-Creation-Date: 2025-01-28T08:15:05.046Z\n" "Last-Translator: Plone i18n \n" "Language-Team: Plone i18n \n" "MIME-Version: 1.0\n" @@ -2174,6 +2174,11 @@ msgstr "" msgid "feedback_error" msgstr "" +#: components/ItaliaTheme/CustomerSatisfaction/FeedbackForm +# defaultMessage: Feedback form +msgid "feedback_form_aria_title" +msgstr "" + #: components/ItaliaTheme/CustomerSatisfaction/FeedbackForm # defaultMessage: Next msgid "feedback_form_button_next" @@ -2974,6 +2979,11 @@ msgstr "" msgid "paginationLabel" msgstr "" +#: components/ItaliaTheme/Header/ParentSiteMenu +# defaultMessage: Main site menu +msgid "parent_site_menu" +msgstr "" + #: components/ItaliaTheme/View/EventoView/EventoCosE # defaultMessage: Parteciperanno msgid "parteciperanno" @@ -3895,6 +3905,11 @@ msgstr "" msgid "skiplink-navigation" msgstr "" +#: components/ItaliaTheme/SkipLinks/SkipLinks +# defaultMessage: Skiplinks +msgid "skiplinks-description" +msgstr "" + #: components/ItaliaTheme/View/PuntoDiContattoView/PuntoDiContattoView #: helpers/contentHelper # defaultMessage: Skype diff --git a/src/components/ItaliaTheme/CustomerSatisfaction/FeedbackForm.jsx b/src/components/ItaliaTheme/CustomerSatisfaction/FeedbackForm.jsx index 7710cf2dd..a80b57dea 100644 --- a/src/components/ItaliaTheme/CustomerSatisfaction/FeedbackForm.jsx +++ b/src/components/ItaliaTheme/CustomerSatisfaction/FeedbackForm.jsx @@ -32,6 +32,10 @@ const messages = defineMessages({ id: 'feedback_form_title', defaultMessage: 'How clear is the information on this page?', }, + aria_title_feedback: { + id: 'feedback_form_aria_title', + defaultMessage: 'Feedback form', + }, yes: { id: 'feedback_form_yes', defaultMessage: 'Yes', @@ -255,7 +259,11 @@ const FeedbackForm = ({ title, pathname }) => { -
+
{ + const intl = useIntl(); const dropdownMenu = useSelector( (state) => state.dropdownMenuNavItems?.result, ); @@ -39,7 +48,11 @@ const ParentSiteMenu = () => { } return subsite && menu ? ( -