Skip to content

Release 1.17.0
Compare
Choose a tag to compare
@DeeDeeG DeeDeeG released this 08 Feb 23:24
· 52 commits to develop since this release
1.17.0
dd5441e
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode.

Pull Request for this release: #614

  • CSS: Center logo and brand name on narrow screens (#611)
  • Tweak CSS a bit for narrow screens (e.g. mobile phones) (#610)
  • Update some dependencies, fix some deprecation warnings (#609)
  • restrooms_spec.rb: Fix a test (#608)
  • db/schema.rb: Commit with underscores in date (297980c)
  • CONTRIBUTING.md: Remove the reference to "Cmd + C" (da6e0e2)
  • PR #607: Minor tweaks/cleanup (c6dc441)
  • Webpack Upgrade (#607)
  • Dockerfile: Upgrade Node from v10.x to v12.x (#603)
  • Fix Travis tests failing on distributions other than trusty (#606)

Compare: 7381796...dd5441e

Full commit log of changes (click to expand): 
commit dd5441e7d2d29201967dc69c76017a2bfb7a1fe6
Author: DeeDeeG <[email protected]>
Date:   Tue Jan 28 15:47:41 2020 -0500

    CSS: Center logo and brand name on narrow screens (#611)
    
    * _mobile.scss: Lower logo/brand on narrow screens
    
    Adjust the CSS "top" property to set the logo and "brand name"
    ("Refuge Restrooms") slightly lower within the navbar on narrow
    screens.
    
    This is to adjust for the navbar being responsively taller
    on narrower screens. "767px screen width" happens to be the responsive
    threshold for that height change for the navbar.
    
    * _mobile.scss: Move 342px rules, adjust whitespace
    
    Moved the "max 342px" rules to the bottom, so all screen-width-related
    style rules are in descending order of the sizes that they apply to.
    (For consistency).
    
    Adjusted the use of newlines in this stylesheet to be more consitent.

commit 61e5df4406b2b9c5a9a6eba78c058b4cbbafcfb0
Author: DeeDeeG <[email protected]>
Date:   Sun Jan 5 12:18:29 2020 -0500

    Tweak CSS a bit for narrow screens (e.g. mobile phones) (#610)
    
    * CSS: Add some styles for narrow screens
    
    For screen widths ~340px or narrower.
    
    (Such a narrow screen is found, for example, on the original iPhone
    through to the iPhone 5S and iPhone SE.)
    
    - Makes the "+" icon on the "Add A Restroom" button
      appear in a more correct-looking position.
    
    - Fixes the overlap of the "Refuge Restrooms" text
      with the "hamburger" drop-down menu button in the header/nav section.
    
    - Adds a class via the haml source (.nav-column)
      to make applying one of the style rules easier.
    
    * CSS: No double-padding on nested `.container`s
    
    Eliminate double-padding in cases of
    an [element].container immediately inside another [element].container.
    
    (Doing this only directly under the header div, just to be conservative.)
    
    The 15px + 15px = 30px of padding on both sides
    seemed unintentionally wide. Also, I think this looks nicer.
    Helps with the tight fit on mobile devices, too.
    
    (Should affect the header/nav on all pages other than the home page,
    aka the splash page, due to the way the pages are coded.)

commit 89c835528ef0fe545d80c7273d563b70e0d9970a
Author: DeeDeeG <[email protected]>
Date:   Sun Jan 5 11:54:01 2020 -0500

    Update some dependencies, fix some deprecation warnings (#609)
    
    * Gemfile[.lock]: Update simplecov
    
    Fixes a deprecation warning
    
    * restrooms_spec.rb: Use 'successful' not 'success'
    
    Rspec's `be_success` and `.success?` are deprecated.
    
    Rspec's `be_successful` and `.successful?`
    are the non-deprecated versions of this check.
    
    (This fixes the associated deprecation warning)
    
    * Gemfile.lock: Bump some dependencies
    
    Upgraded loofah, puma, rack, and rack-cors,
    plus their dependencies.

commit 3714303e85387050227d0f3439ecdc3f118dcef4
Author: DeeDeeG <[email protected]>
Date:   Tue Dec 24 17:55:25 2019 -0500

    restrooms_spec.rb: Fix a test (#608)
    
    Background:
    
    The Mission Creek Cafe in San Francisco has been closed for some time.
    
    Google Maps API now resolves "Mission Creek Cafe"
    to a coffee shop in Washington state.
    
    Washington is too far away from our stub restroom entries;
    No stub restrooms are located near Washington,
    so no restroom results are shown on our results page for this search.
    
    The test expects to see a stub restroom entry on the reults page,
    but does not see it, and so the test fails.
    
    ---
    
    Fix:
    
    search the Maps API for "San Francisco," not "Mission Creek Cafe"
    
    (This returns a lat/long associated with San Francisco not Washington)

commit 297980c3a0f8c6ec6abcbf5b63d4a4f97da01f6f
Author: DeeDeeG <[email protected]>
Date:   Mon Dec 23 21:37:00 2019 -0500

    db/schema.rb: Commit with underscores in date
    
    The date gets underscores added automatically
    when running migrations on the database.
    
    Committing with the underscores so the change isn't flagged by git
    when no code has been changed.

commit da6e0e2cc8986dbbe6169275d4196c0db5dc56e6
Author: DeeDeeG <[email protected]>
Date:   Fri Dec 20 22:46:56 2019 -0500

    CONTRIBUTING.md: Remove the reference to "Cmd + C"
    
    The "Cmd + C" keyboard shortcut is for copying text,
    not quitting programs in the terminal.
    
    The proper way to quit programs in the terminal
    under macOS is "Ctrl + C", the same as Linux.
    
    Referring to "Cmd + C" here was based on
    a mistaken assumption that "Ctrl" on Windows or Linux
    always gets translated to "Cmd" on macOS.
    
    (In fact, some uses of "Ctrl" on Windows/Linux
    are preserved as-is on macOS. It's a mixed bag.)
    
    Deleting the reference to "Ctrl + C", to make the guidance clearer.

commit c6dc441dc100a1e4cf16c519adf2887a5302ff86
Author: DeeDeeG <[email protected]>
Date:   Fri Dec 20 20:08:17 2019 -0500

    PR #607: Minor tweaks/cleanup
    
    - Adjust Gemfile[.lock] to specify webpacker within the 4.x series,
      rather than any version 4.0 or greater.
    
    - Delete some duplicate entries in the .gitignore file

commit 01c3c2111128f47136bec535de4998398ac0c632
Author: Emily Ring <[email protected]>
Date:   Fri Dec 20 19:53:08 2019 -0500

    Webpack Upgrade (#607)
    
    * Updated webpacker gem
    
    * Upgraded yarn packages
    
    * Ran webpack:install process.  Working without rails-erb-loader
    
    * Added rails-erb-loader to webpack
    
    * Fixed include PgSearch warning
    
    * Added .dockerignore

commit 5154cd1c29069f74dd8b41b25ed08c9228c40599
Author: DeeDeeG <[email protected]>
Date:   Fri Nov 1 16:58:40 2019 -0400

    Dockerfile: Upgrade Node from v10.x to v12.x (#603)
    
    Node 12 "Erbium" is the newest Long Term Service release.
    
    We should either pin a version of Node in our package.json file,
    or stay on the latest LTS version of Node;
    
    Heroku will use the latest LTS version of Node
    in production if we don't have any versions pinned in our package.json

commit 6c9636877c24aed5b40a80982165dd761170aa0a
Author: Jason Chen <[email protected]>
Date:   Fri Nov 1 16:52:29 2019 -0400

    Fix Travis tests failing on distributions other than trusty (#606)
    
    * Revert ".travis.yml: Set "dist" to "trusty" (#600)"
    
    This reverts commit ac8f6aba3e4fe2d5728c5809b2b61ed91c0b5432.
    
    Doing this to run tests on Travis to investigate why they
    aren't passing.
    
    * Explicitly require locations.rb in rspec.rb
    
    Tentative fix for tests not passing in xenial but passing in trusty.
    This might be because different distributions load files in a
    different order. In xenial, `rspec.rb` might get loaded before
    `locations.rb`, making `Locations` uninitialized. Explicit require
    fixes this.

commit 73817966a0559dcee525def971c1082050f7b510
Merge: 05c74cb 699d846
Author: Teagan <[email protected]>
Date:   Tue Oct 29 13:15:10 2019 -0700

    Merge branch 'master' into develop
Assets 2
Loading