You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When resetting the CPU data (by clicking the gear button), the time does not reset to that moment but stays as time since last UI reload. This skews the calls/sec data negatively from reality after clicking it once. Changing the function CPU:GetLoadedTime() to instead return max(floor(GetTime() - self.loadedtime or ElvUI.loadedtime), 1) on line 109 lets the updated CPU.loadedtime call on line 262 to be used for these calculations instead of the constant time since UI reload. The max function is needed to avoid divide by zero issues.
This does not fix the calculations when doing a manual garbage dump (like shift-clicking the system datatext provided by ElvUI) which will still exhibit the incorrect timing as it is currently (since CPU.loadedtime isn't updated when doing this).
Maybe this is the intended behavior as Sympy alluded to in discord, but I think this change generally makes the data in the calls/sec column more accurate and valuable.
The text was updated successfully, but these errors were encountered:
When resetting the CPU data (by clicking the gear button), the time does not reset to that moment but stays as time since last UI reload. This skews the calls/sec data negatively from reality after clicking it once. Changing the function CPU:GetLoadedTime() to instead
return max(floor(GetTime() - self.loadedtime or ElvUI.loadedtime), 1)
on line 109 lets the updated CPU.loadedtime call on line 262 to be used for these calculations instead of the constant time since UI reload. The max function is needed to avoid divide by zero issues.This does not fix the calculations when doing a manual garbage dump (like shift-clicking the system datatext provided by ElvUI) which will still exhibit the incorrect timing as it is currently (since CPU.loadedtime isn't updated when doing this).
Maybe this is the intended behavior as Sympy alluded to in discord, but I think this change generally makes the data in the calls/sec column more accurate and valuable.
The text was updated successfully, but these errors were encountered: