River: Removing a road while a soldier is crossing sometimes hangs the game

[kranzj]

Hi!

I'm lately into river games with my brother, i.e. I like those maps that have rivers which can only be crossed if a player can build a road across them. Part of the strategy around those rivers is to build and remove roads, sometimes as soldiers cross the water. In some cases, roughly maybe ~25% of the cases, when one removes a road while the soldier is crossing the game hangs.

Affected version: latest nightly, platform is Linux+Windows (two players, both hang)

Thanks for taking a look!

By the way: I'm playing this game weekly, and it's literally the first game I've ever played on a computer back when I was 10. Thanks to everyone who has worked so hard to bring this back as open source!

[Flamefire]

Can you create a short replay to show the issue please? I.e. start a new game, do something to create the issue as fast as possible, then quit and attach the replay here (in ~/.s25rttr/REPLAYS)

[kranzj]

Sorry for the delay; when we tried to intentionally get it to crash, of course it never did; however, today it hung again during one of our usual games. Sorry for the longer replay, but this one ends in the crash (the game also hangs at the end of the replay). To see, jump to GF 55000 and notice how the soldier is passing the river as the small military building is conquered, leading to the crash.

2024-08-28_23-58-53.rpl.zip