Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set https urls for packages #4669

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

facumenzella
Copy link
Contributor

Motivation

This is a follow-up of #4661

  • The url keeps changing from ssh to https.
  • Tweak how nimble is declared as a dependency

@facumenzella facumenzella added the pr:fix A bug fix label Jan 15, 2025
Copy link
Member

@ajpallares ajpallares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. However, let's have someone else take a look to make sure that they can properly resolve packages versions and doing so does not create diffs in Package.resolved for them

@facumenzella facumenzella enabled auto-merge (squash) January 15, 2025 10:18
@facumenzella facumenzella merged commit 38e7ce3 into main Jan 15, 2025
9 of 10 checks passed
@facumenzella facumenzella deleted the fix/fix-https-extra-package branch January 15, 2025 10:25
@facumenzella
Copy link
Contributor Author

@RCGitBot please test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:fix A bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants