[Paywalls V2] Fix footer positioning and bottom padding #4746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 build decreased size
Paywalls 1.0 (1)
|
| Item | Install Size Change |
|---|---|
| DYLD.String Table | ⬇️ -2.6 kB |
| Other | ⬆️ 2.5 kB |
View Treemap
🛸 Powered by Emerge Tools
joshdholtz
changed the base branch from
main
to
paywalls-v2/add-full-cover-option-to-paywalls-tester
📸 Snapshot Test2 modified, 169 unchanged
🛸 Powered by Emerge Tools |
joshdholtz
force-pushed
the
paywalls-v2/add-full-cover-option-to-paywalls-tester
branch
from
eec3175 to
cc82b4f
Compare
joshdholtz
force-pushed
the
paywalls-v2/fix-footer-bottom-positioning-and-padding
branch
from
962c5e2 to
daa202d
Compare
ajpallares
approved these changes
Jan 30, 2025
joshdholtz
force-pushed
the
paywalls-v2/add-full-cover-option-to-paywalls-tester
branch
from
cc82b4f to
1e2e423
Compare
joshdholtz
force-pushed
the
paywalls-v2/fix-footer-bottom-positioning-and-padding
branch
from
daa202d to
d15816a
Compare
MarkVillacampa
approved these changes
Jan 30, 2025
joshdholtz
force-pushed
the
paywalls-v2/add-full-cover-option-to-paywalls-tester
branch
from
1e2e423 to
8abb7fa
Compare
Base automatically changed from
paywalls-v2/add-full-cover-option-to-paywalls-tester
to
main
January 30, 2025 11:35
joshdholtz
force-pushed
the
paywalls-v2/fix-footer-bottom-positioning-and-padding
branch
from
d15816a to
16f911b
Compare
joshdholtz
deleted the
paywalls-v2/fix-footer-bottom-positioning-and-padding
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes some margin and padding issues in the sticky footer
Description
Spacer()that was causing some margin on the bottom to show