Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove channel lookup call on Fee Update #1242

Closed
ShahanaFarooqui opened this issue May 16, 2023 · 1 comment · Fixed by #1392
Closed

Remove channel lookup call on Fee Update #1242

ShahanaFarooqui opened this issue May 16, 2023 · 1 comment · Fixed by #1392
Assignees
@ShahanaFarooqui
Labels
Core Lightning medium version compatibility
Milestone
0.15.1

Comments

@ShahanaFarooqui
Copy link
Collaborator

After cl-rest version 0.10.3, list channels will also have fee_base_msat and fee_proportional_millionths fields in response. Channel lookup to get these values is not needed anymore. Remove it after 2 releases to avoid backward compatibility issue.
@ShahanaFarooqui ShahanaFarooqui added this to the Release 0.13.8-beta milestone May 16, 2023
@ShahanaFarooqui ShahanaFarooqui self-assigned this May 16, 2023
@ShahanaFarooqui ShahanaFarooqui modified the milestones: Release 0.14.1-beta, Release 0.14.2-beta Oct 4, 2023
@ShahanaFarooqui ShahanaFarooqui modified the milestones: Release 0.14.2-beta, Release 0.15.0-beta Oct 13, 2023
@ShahanaFarooqui ShahanaFarooqui linked a pull request May 13, 2024 that will close this issue
cln: Removed channel lookup call for update policy #1392
Merged
@ShahanaFarooqui
Copy link
Collaborator Author

Closing with PR #1392

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShahanaFarooqui ShahanaFarooqui

Labels
Core Lightning medium version compatibility
Projects
None yet
Milestone
0.15.1
Development

Successfully merging a pull request may close this issue.

cln: Removed channel lookup call for update policy Ride-The-Lightning/RTL
1 participant
@ShahanaFarooqui