Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bossfights container change #13

Open
Dorian-Grim opened this issue Jul 22, 2024 · 1 comment
Open

bossfights container change #13

Dorian-Grim opened this issue Jul 22, 2024 · 1 comment

Comments

@Dorian-Grim
Copy link

The html targeted

<div id="fights-container-wrap">

Description

Currently the behavior of this element makes the user to move mouse to the left to reach his desired boss fight. Making him move mouse a lot also with the risk of accidentally hiding the fight container if he hovers out

  • Demo of current behavior:
    current bosses container demo
  • Also on mobile device it's kind of bugged because it overlaps:
    UwU Logs - 11 Jul 24, 1905 - Loukxd

Proposed solution fix in PR #8

The fix involves stripping down some css which was enabling the old behavior. It will also improve navigation speed when user wants to quickly go to certain boss and certain fight.

  • Example desktop/mobile:
    desktop and mobile demo

  • Example of navigation:
    bosses container demo 2

  • Also I'm adding a 80vh to the container and a scrollbar for when it's overflown. Example:
    scrollbar demo

  • and visual indication of each expansion. Example:
    image

Demo:
final dmeo

@Dorian-Grim Dorian-Grim mentioned this issue Jul 22, 2024
@Dorian-Grim
Copy link
Author

Merging with PR #8 will implement the demo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant