Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ItemRack adds confusing entries to tooltips on empty inventory slots #250

Closed
Elberet opened this issue Jan 22, 2024 · 2 comments
Closed

Comments

@Elberet
Copy link

Elberet commented Jan 22, 2024

In ItemRack version 3.77 (latest as of reporting this issue), when an equipment slot is empty but enabled to indicate this slot should be unequipped, ItemRack starts adding tooltips to empty itemslots, incorrectly believing that e.g. an empty bag slot is the same as an empty equipment set slot.

Symptoms:

In the options, flyout menus contain a "broken" empty option:
grafik
Additionally, the ItemRack options window shows a ranged weapon slot with the bow icon, and an ammunition slot, even tho my character is a shaman. It does, however, correctly list totems in the "bow" slot flyout menu, and correctly equips and unequips totems.

When hovering over an empty bag slot, a tooltip shows that ItemRack identifies the empty slot as an item in an equipment set:
grafik
The erronous tooltip goes away, if no set contains any empty slots, or if all empty slots in all sets are disabled / ignored.

This error was not present in version 3.75. I am playing WoW WotLK Classic with German localization

@Elberet
Copy link
Author

Elberet commented Jan 22, 2024

I believe the problem is related to this line:

return ItemRack.GetIRString(itemLink)..runeSuffix

The string concatenation causes ItemRack.GetID to always return a string. Callers that previously tested item IDs with itemID ~= 0 will no longer work, since that comparison is type sensitive.

@Rottenbeer
Copy link
Owner

Please retest with 4.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants