Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Items not going into bank or being pulled from bank when clicking a set. #266

Closed
Immodium opened this issue Jun 7, 2024 · 7 comments
Closed

Comments

@Immodium
Copy link

Immodium commented Jun 7, 2024

Before cata pre-patch I was able to go to the bank and pull out or toss in a set depending on which one I clicked. Now when I do that nothing happens.

I looked through the issues logs and didn't see a fix for it? Sorry if this a duplicate, but I would like to know how to fix it.

@justmuddgaming
Copy link

+1 to this happening to me in cata

@Xdembe
Copy link

Xdembe commented Jun 22, 2024

elseif ItemRack.IsBCC() or ItemRack.IsWrath() then

change this line to
elseif ItemRack.IsBCC() or ItemRack.IsWrath() or ItemRack.IsCata() then

@Immodium
Copy link
Author

elseif ItemRack.IsBCC() or ItemRack.IsWrath() then

change this line to
elseif ItemRack.IsBCC() or ItemRack.IsWrath() or ItemRack.IsCata() then

That worked, thank you!

@Rottenbeer
Copy link
Owner

Should be fixed by #277

@trying-to-function
Copy link

@Rottenbeer this is still not working on Season of Discovery.

@trying-to-function
Copy link

Additionally, this is the error that is being thrown:

69x ItemRack/ItemRack.lua:43: bad argument #1 to 'IsInventorySlotEngravable' (outside of expected range 0 to 4294967295 - Usage: local result = C_Engraving.IsInventorySlotEngravable(containerIndex, slotIndex))
[string "=[C]"]: in function `IsInventorySlotEngravable'
[string "@ItemRack/ItemRack.lua"]:43: in function `AppendRuneID'
[string "@ItemRack/ItemRack.lua"]:709: in function `getid'
[string "@ItemRack/ItemRack.lua"]:822: in function `FindInBank'
[string "@ItemRack/ItemRack.lua"]:2180: in function `MissingItems'
[string "@ItemRack/ItemRack.lua"]:1264: in function `BuildMenu'
[string "@ItemRack/ItemRack.lua"]:1920: in function `OnClick'
[string "@BugSack/Libs/LibDBIcon-1.0-55/LibDBIcon-1.0.lua"]:179: in function <BugSack/Libs/LibDBIcon-1.0/LibDBIcon-1.0.lua:177>

Locals:
(*temporary) = -1
(*temporary) = 1
(*temporary) = "outside of expected range 0 to 4294967295 - Usage: local result = C_Engraving.IsInventorySlotEngravable(containerIndex, slotIndex)"

@trying-to-function
Copy link

Did further research and found arkayenro/arkinventory#2019. I am not sure this is the correct fix, but I changed line 36 of ItemRack.lua to return C_Engraving and blizzard_id ~= nil and C_Engraving.IsEngravingEnabled() and it seems to work.

See also:
https://us.forums.blizzard.com/en/wow/t/sod-engraved-items-in-the-bank-isinventoryslotengravable-bug/1964618

You can look at the git changes arkayenro did to fix the issue: ArkInventory-3.11.01-alpha-7-with-git-changes-from-6.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants