Hotswap Weakaura and Itemrack no longer work (Classic Era 1.15.4)

[maximus210793]

Hi,
Warrior Hotswap (https://wago.io/djN0VftGP/3) does not longer work since version update.
Chat Message with newest Version says: "ItemRack: Swap stopped. Something is on the cursor."

I am playing WoW Classic Era V1.15.4.
See also: #254

Thank you for fixing it.

[Rottenbeer]

Which ItemRack version did you test?

[Rottenbeer]

Try 4.2

[maximus210793]

both 4.2 and 4.21 are not working, they also miss this change in the ItemRackEquip.lua:
Change Line 283 in "ItemRackEquip.lua"
from
283: if swap[k]==0 then -- if intended to be empty
to
283: if swap[k]==0 or swap[k]=="0" then -- if intended to be empty

[Rottenbeer]

Can you make an PR please?

[maximus210793]

what is PR release?

[Rottenbeer]

A PR is a pull request here on github.
I merge and release it afterwards.

[maximus210793]

I have no clue what to do sry :(
I only know that the solution from #254 worked:
Change Line 283 in "ItemRackEquip.lua"
from
283: if swap[k]==0 then -- if intended to be empty
to
283: if swap[k]==0 or swap[k]=="0" then -- if intended to be empty

[maximus210793]

Update:
Version 4.21 now working for me.
But in the ItemRackEquip.lua it says in line 283: if swap[k]==0 then -- if intended to be empty
Did you fix it somewhere else in the code since it is not saying:
283: if swap[k]==0 or swap[k]=="0" then -- if intended to be empty
?

[Rottenbeer]

The PR had two different solutions and fixed it somewhere else.
See #259

[maximus210793]

Still having problems with changing gear sets, when one has a shirt equipped and the other one not.
Producing a "Swap stopped. Something is on the cursor" error.
Even with changing line 283 to if swap[k]==0 or swap[k]=="0" then -- if intended to be empty