Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add a localization manager #435

Closed
MarioSwitch opened this issue Dec 23, 2024 · 1 comment
Closed

[Feature Request] Add a localization manager #435

MarioSwitch opened this issue Dec 23, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@MarioSwitch
Copy link

Overview

Link a localization manager to this repository to have better management of translations.

Smaller details

For example, Weblate or Crowdin are famous to do this nicely!

Nature of request

Helping potential translators to translate even without knowing where is the localization file / how to edit this file and create a GitHub PR.

Why would this feature be useful?

As of now, the only way to update/add translations are to edit manually the locales file...
First, this file is now 21k lines long which freezes web browser when loading
Secondly, it is in /src/Ryujinx/Assets/locales.json which is pretty hidden and difficult to find
Thirdly, as explained above, creating a PR isn't given to everyone

@MarioSwitch MarioSwitch added the enhancement New feature or request label Dec 23, 2024
@GabCoolDude GabCoolDude changed the title [Feature Request] Please add a localization manager [Feature Request] Add a localization manager Dec 23, 2024
@GreemDev
Copy link
Member

Frankly this would be a nightmare.
As it is GitHub creates conflicts for merges to the locales.json file for languages that are near each other in the translation listing. This has happened many times for Norwegian and Korean translations for example.
I don't have any idea how those websites would handle the conflicts.
Even if it did handle it well, I'm already insanely drained from running this project as it is, without adding in another stream for potential contributions.

If making a PR is hard, you can always just come into the Discord and send the file with your changes for me to push with a co-authored commit, or for me to make a PR directly. I mean this as a more general statement and not just targeted at you btw

@GreemDev GreemDev closed this as not planned Won't fix, can't repro, duplicate, stale Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants