Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make download of binary more resilient #21

Open
CCFenner opened this issue Sep 11, 2020 · 1 comment
Open

make download of binary more resilient #21

CCFenner opened this issue Sep 11, 2020 · 1 comment

Comments

@CCFenner
Copy link
Member

Bildschirmfoto 2020-09-11 um 18 17 15

In this concrete case the piper_master binary was unavailable. The action should be more resilient in this case and download the latest release.
@CCFenner CCFenner mentioned this issue Sep 11, 2020
Closed
@fwilhe
Copy link
Contributor

fwilhe commented Sep 14, 2020

You can always change piper-version as a last resort. I'm not sure how much "magic" we should put into that, because the case we had here clearly violated the assumptions this action was based on. We could probably handle the 404 case more gracefully, but the number of possible failures is very large.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fwilhe @CCFenner