Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new comparison metrics #22

Open
chilge opened this issue Oct 8, 2021 · 2 comments
Open

Add new comparison metrics #22

chilge opened this issue Oct 8, 2021 · 2 comments
Assignees
@chilge
Labels
enhancement New feature or request

Comments

@chilge
Copy link
Contributor

chilge commented Oct 8, 2021

We currently compare reference and test validation histograms with a simple chi-squared. We should also consider adding other statistical tests that may be more appropriate when statistical fluctuations are unavoidable, e.g. the Kolmogorov–Smirnov (KS) test. The KS test has been implemented in ROOT'. See TH1::KolmogorovTest.
@chilge chilge added the enhancement New feature or request label Oct 8, 2021
@wesketchum
Copy link

@chilge Don't know if this is on timescale for 2021C release or not: if not, we should push to the next release/sometime before the next release.

@chilge
Copy link
Contributor Author

chilge commented Nov 8, 2021

This definitely should get pushed to the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chilge chilge

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wesketchum @chilge