Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break CAFMaker out into its own package #265

Open
cjbacchus opened this issue May 12, 2022 · 2 comments
Open

Break CAFMaker out into its own package #265

cjbacchus opened this issue May 12, 2022 · 2 comments

Comments

@cjbacchus
Copy link
Contributor

Otherwise sim/reco fixes and CAF-making fixes can each interrupt the other's production by requiring new releases to be cut.

The biggest question is what to actually call the repo. sbnanaobjmaker???

@wesketchum
Copy link
Contributor

I think this may be good to try to push through ASAP (as in, next few weeks if possible), or at least discuss a better structure and try to implement before you are gone @cjbackhouse . Do you think that's possible? What will need doing?

@PetrilloAtWork @FernandaPsihas thoughts?

(Could be correlated with other breaking changes in CAFs...?)

@cjbacchus
Copy link
Contributor Author

I took a shot at this a while back. There's a post June 9th in #analysis_software
This is the sbncafmaker repo (with automatically rewritten history)
https://github.com/SBNSoftware/sbncafmaker/tree/develop/sbncafmaker
We would still need to file an issue against mrb to get it added to the list of packages.
sbncode branch with CAFMaker removed (this is a much simpler operation) https://github.com/SBNSoftware/sbncode/tree/feature/cafmaker_migration

There was an issue with a directory - RecoUtils - that is needed both by CAFMaker but also by NumuSelection that lives in sbncode. I talked to @grayputnam about this briefly with no real resolution.

I don't remember what I do with it in my branches. Either they don't build, or important things are commented out. You should definitely look at them before blindly merging them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants