Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reconstructed time to CAF particle record #311

Open
PetrilloAtWork opened this issue Oct 24, 2022 · 4 comments
Open

Add reconstructed time to CAF particle record #311

PetrilloAtWork opened this issue Oct 24, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@PetrilloAtWork
Copy link
Member

Pandora is sometimes able to tag a particle with a time (cathode-crossing tracks are the case in ICARUS and presumably SBND).
The information of that time should be stored in CAF data.
In fact, it may be conceivable that several time estimations are available (from matching with light, with CRT, and from TPC reconstruction, for example) and one might even want to accommodate all of them and let the analyser choose which one they believe most.

Anyway, for this one, a default value of "non-assigned" is needed, and then I recommend the time to be stored in the standard CAF time unit and with the same time reference as the reconstructed optical flashes (beam gate time? this point is topic of a different discussion).

@PetrilloAtWork PetrilloAtWork added the enhancement New feature or request label Oct 24, 2022
@wesketchum
Copy link
Contributor

Is this PR fixing this issue? #308

@gputnam
Copy link
Contributor

gputnam commented Nov 1, 2022

@PetrilloAtWork can confirm -- but I believe it goes some of the way.

It does add in the cathode crossing time for slices that have one.

@wesketchum
Copy link
Contributor

@PetrilloAtWork should this be left open? going to move to a different release at the least ... but would be good to close if we can.

@PetrilloAtWork
Copy link
Member Author

I think PR #308 addressed it for the time being.
We'll want the time from PMT and CRT when they become available, but that's not for the current release.
Up to you if you prefer to close this one or move its target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants