From f3905af0edd7a179c0722e9d77384bb4e7bbe663 Mon Sep 17 00:00:00 2001 From: Jim Lin <133722877+jimlin-sfgov@users.noreply.github.com> Date: Wed, 22 Jan 2025 15:45:31 -0800 Subject: [PATCH] fix: DAH-3181 Handle invalid listings when logging translation usage (#2510) fix: handle invalid listings when logging translation usage --- app/services/force/listing_service.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/services/force/listing_service.rb b/app/services/force/listing_service.rb index 58ed63768..099d2a3bc 100644 --- a/app/services/force/listing_service.rb +++ b/app/services/force/listing_service.rb @@ -40,7 +40,7 @@ def self.listing(id, opts = {}) results = Request.new(parse_response: true).cached_get(endpoint, nil, force) listing = process_listing_images(results) - translation_usage_by_trigger(listing, opts[:rake_task]) + translation_usage_by_trigger(listing, opts[:rake_task]) if listing.present? if Rails.configuration.unleash.is_enabled? 'GoogleCloudTranslate' listing['translations'] = get_listing_translations(listing) || {} @@ -51,7 +51,7 @@ def self.listing(id, opts = {}) def self.translation_usage_by_trigger(listing, rake_task = nil) # only one of these feature flags should be turned on at a time if Rails.configuration.unleash.is_enabled?( - 'LogGoogleCloudTranslateUsageForPageView' + 'LogGoogleCloudTranslateUsageForPageView', ) && rake_task.blank? listing['translations'] = log_listing_translations(listing, 'page_view') elsif Rails.configuration.unleash.is_enabled?(