Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] UTF-8 Preset Names #1

Open
sylvia-leaf opened this issue Nov 9, 2024 · 1 comment
Open

[FEATURE REQUEST] UTF-8 Preset Names #1

sylvia-leaf opened this issue Nov 9, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@sylvia-leaf
Copy link

Is your feature request related to a problem? Please describe.
Spessasynth cannot decode preset names that are in UTF-8; it can only work with Ascii characters. This is a significant problem as some users may want to use Kana or CJK characters (Kanji) in their preset names.

Is your feature related to the sound library or the app/website?
App/website

Describe the solution you'd like
Make sure that preset names entered in UTF-8 render correctly.

Describe alternatives you've considered
SFe only recently included UTF-8 support for preset names (4.00.9), so nothing.

Additional context
SFe 4.00.9 now permits the use of UTF-8 in preset, instrument and sample names. Previously, UTF-8 was only permitted in the info-list chunk and not pdta.

@sylvia-leaf sylvia-leaf added the enhancement New feature or request label Nov 9, 2024
@sylvia-leaf sylvia-leaf self-assigned this Nov 9, 2024
@sylvia-leaf sylvia-leaf moved this to Backlog in SFe 4 format Feb 8, 2025
@sylvia-leaf sylvia-leaf added this to the v3.24.1-SFe milestone Feb 8, 2025
@spessasus
Copy link
Member

This is going to be a problematic one. You see, the soundfont parser has to woth both in the main thread and the AudioWorklet thread. The latter of which doesn't have the TextDecoder interface available, so currently spessasynth just uses String.fromCharCode

So the only way would be to implement our own UTF-8 decoder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

2 participants