Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nominalFocalLength is undefined for zoom lenses #164

Open
jamesmosys opened this issue Feb 12, 2025 · 1 comment
Open

nominalFocalLength is undefined for zoom lenses #164

jamesmosys opened this issue Feb 12, 2025 · 1 comment

Comments

@jamesmosys
Copy link
Collaborator

Zoom lenses are defined by a nominal minimum and maximum focal length. Currently the static packet only support a single number for this - which covers the prime lens case e.g. 50mm.

@JGoldstone
Copy link
Contributor

What I could do is to set the nominal focal length for a zoom lens if the value during the sequence never changed more than 0.5mm; if it stayed within that range, basically just registering a zoom that wasn't being used as a zoom, I'd take the average value. But that's pretty complex semantics. For the first cut at PR I just won't set the attribute if the values differ at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants