Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Adjust Padding for Logos on Home Page #3504

Open
ssw-yakshaver bot opened this issue Jan 15, 2025 · 1 comment
Open

✨ Adjust Padding for Logos on Home Page #3504

ssw-yakshaver bot opened this issue Jan 15, 2025 · 1 comment

Comments

@ssw-yakshaver
Copy link

ssw-yakshaver bot commented Jan 15, 2025

Requested by: @Calinator444 via YakShaver.ai 🦬
cc: @wicksipedia, @adamcogan, @brookjeynes-ssw, @tiagov8

Hi Team!

Watch the video

Url: ssw.com.au

Pain

The home page for the SSW Website (Dev - Next.js) has logos with too much padding. The current padding is set to 1 REM, and it might need to be reduced to 0.5 REM.

Acceptance Criteria

  1. Logo padding reduced
  2. Changes are approved by Tiago

Screenshot

Screenshot
Figure: Key decision: Agreement on reducing logo padding from one REM to 0.5 REM.

@tiagov8
Copy link
Member

tiagov8 commented Jan 16, 2025

Hi @Calinator444

In fact we don't need to touch the paddings, just need to remove these 2rem margins (top and bottom) from the logo images (see screenshots below)

Note: I assume the margins are set to any image in content, so we need to remove them just for the logos section (e.g. use the logo section class or id to say images in it should not have the margins)

Image Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🤷‍♂️ Needs Triage
Development

No branches or pull requests

1 participant