Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Date binaries + move JS engines binarie to github #9

Open
damorim opened this issue Apr 21, 2018 · 5 comments
Open

add Date binaries + move JS engines binarie to github #9

damorim opened this issue Apr 21, 2018 · 5 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@damorim
Copy link
Collaborator

damorim commented Apr 21, 2018

Igor told me there was a missing library under js_engine. Please update the .zip so that we don't spend time analyzing those kinds of crashes.

@damorim damorim added the bug Something isn't working label Apr 21, 2018
@igor-simoes
Copy link
Collaborator

Do you think that we can push the zip to our repo? (currently, our binaries.zip is only 30mb)

  1. If we update the new version, everyone will know
  2. Less manual configuration (just pull repo and extract it)
  3. It's not necessary download on external urls

@damorim
Copy link
Collaborator Author

damorim commented Apr 21, 2018

How long would it take for someone abroad (say, Mateus) to pull? Is there a space limit on GitHub? @MateusAraujoBorges, what do you think?

@igor-simoes
Copy link
Collaborator

igor-simoes commented Apr 22, 2018

According GitHub docs:

Personal and organization accounts using Git LFS receive 1 GB of free storage and 1 GB a month of free bandwidth

https://help.github.com/articles/about-storage-and-bandwidth-usage/

@damorim
Copy link
Collaborator Author

damorim commented Apr 23, 2018

Sounds good to me. @MateusAraujoBorges, what do you think?

@damorim damorim changed the title add Date binaries add Date binaries + move JS engines binarie to github Apr 23, 2018
@damorim damorim added the enhancement New feature or request label Apr 23, 2018
@MateusAraujoBorges
Copy link
Contributor

Seems like Git LFS may do the trick for now (1GB may go out fast if we start recompiling the interpreters often).

igor-simoes added a commit that referenced this issue Apr 25, 2018
igor-simoes added a commit that referenced this issue Apr 26, 2018
igor-simoes added a commit that referenced this issue Apr 26, 2018
igor-simoes added a commit that referenced this issue Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants