-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Outdated markup #6
Comments
As you may guess, we don't have a front-end dev at all, and the position is open in our organization (also we lack a wiki administrator/authors as for now) |
I'm supposed to learn MediaWiki at work (my first "professional" PHP involvement). I'll take care for theming there. Could be worthwhile :-) |
While going through the code (see #2) I found several issues, which I'll fix with an upcoming PR.
margin-bottom:1em
for each<br />
to stretch the space below an element.display:block
to each (and thereby getting rid of<br />
s.<center>
is outdated. If you want to center an inline element, usetext-align:center
(or add a classtext-center
), if it is a block element, usedisplay:block;margin-left:auto;margin-right:auto
(or add a classcenter-block
).<b>
is outdated. If you want to have something visually bold, addfont-weight:bold
style to it. If it conveys a meaning, use<strong>
instead of<b>
.<em>
is not as "semantic heavy" as<strong>
(and could be styled to look bold, if you like).The text was updated successfully, but these errors were encountered: