Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated markup #6

Open
Ryuno-Ki opened this issue Apr 1, 2016 · 3 comments
Open

Outdated markup #6

Ryuno-Ki opened this issue Apr 1, 2016 · 3 comments

Comments

@Ryuno-Ki
Copy link
Collaborator

Ryuno-Ki commented Apr 1, 2016

While going through the code (see #2) I found several issues, which I'll fix with an upcoming PR.

  • Looks like your front-end dev was on vacation - please increase margin-bottom:1em for each <br /> to stretch the space below an element.
  • You can enforce line-break between elements by assigning display:block to each (and thereby getting rid of <br />s.
  • <center> is outdated. If you want to center an inline element, use text-align:center (or add a class text-center), if it is a block element, use display:block;margin-left:auto;margin-right:auto (or add a class center-block).
  • <b> is outdated. If you want to have something visually bold, add font-weight:bold style to it. If it conveys a meaning, use <strong> instead of <b>. <em> is not as "semantic heavy" as <strong> (and could be styled to look bold, if you like).
  • If a link takes you to another HTML document, it's a link. So don't declare it a button with the role-attribute, please.
  • An ID must be assigned exactly once per document (I found several flavours and getits).
@mudler
Copy link
Member

mudler commented Apr 2, 2016

As you may guess, we don't have a front-end dev at all, and the position is open in our organization (also we lack a wiki administrator/authors as for now)
I can't work on that right now, there are other priorities in my list (i take care of infra, overlay, maintenance and project lead) I'll be however very glad to look at the PR and merge it asap :)

@Ryuno-Ki
Copy link
Collaborator Author

Ryuno-Ki commented Apr 2, 2016

I'm supposed to learn MediaWiki at work (my first "professional" PHP involvement). I'll take care for theming there. Could be worthwhile :-)

Ryuno-Ki pushed a commit to Ryuno-Ki/sabayon-website-next that referenced this issue Apr 2, 2016
mudler added a commit that referenced this issue Apr 3, 2016
@Ryuno-Ki
Copy link
Collaborator Author

sabayon-theme-rewrite

Just as an insight i what I am doing these evenings :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants