Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging/toasts via services.shared.lsp.Connection #1002

Closed
lars-reimann opened this issue Apr 7, 2024 · 1 comment · Fixed by #1007
Closed

Logging/toasts via services.shared.lsp.Connection #1002

lars-reimann opened this issue Apr 7, 2024 · 1 comment · Fixed by #1007
Assignees
@lars-reimann
Labels
cleanup 🧹 Refactorings and other tasks that improve the code released Included in a release

Comments

@lars-reimann
Copy link
Member

Currently, the VS Code extension injects logging capabilities after creating a services object. Extensions for other language clients would need to do the same.

Instead, we can send messages to the client via

  • services.shared.lsp.Connection.console, and
  • services.shared.lsp.Connection.window.
@lars-reimann lars-reimann added the cleanup 🧹 Refactorings and other tasks that improve the code label Apr 7, 2024
@lars-reimann lars-reimann added this to DSL Apr 7, 2024
@github-project-automation github-project-automation bot moved this to Backlog in DSL Apr 7, 2024
@lars-reimann lars-reimann self-assigned this Apr 7, 2024
@lars-reimann lars-reimann moved this from Backlog to In Progress in DSL Apr 7, 2024
@lars-reimann lars-reimann mentioned this issue Apr 7, 2024
Merged
lars-reimann added a commit that referenced this issue Apr 7, 2024
@lars-reimann
refactor: move logging callbacks into language server (#1003)
568ee20 
### Summary of Changes

As a first step for #1002, register logging callbacks in the `Runner`
service instead of the extension.
@lars-reimann lars-reimann removed their assignment Apr 7, 2024
@lars-reimann lars-reimann moved this from In Progress to Backlog in DSL Apr 7, 2024
@lars-reimann lars-reimann self-assigned this Apr 8, 2024
@lars-reimann lars-reimann mentioned this issue Apr 8, 2024
Merged
lars-reimann added a commit that referenced this issue Apr 8, 2024
@lars-reimann
refactor: configure messaging when creating services (#1007)
61fd8e6 
Closes #1002

### Summary of Changes

* It's now possible to configure messaging (logging/user messaging) for
when creating services.
* The runner now uses the `MessagingProvider` instead of handling
messaging on its own.
@github-project-automation github-project-automation bot moved this from Backlog to ✔️ Done in DSL Apr 8, 2024
@lars-reimann
Copy link
Member Author

🎉 This issue has been resolved in version 0.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lars-reimann lars-reimann

Labels
cleanup 🧹 Refactorings and other tasks that improve the code released Included in a release
Projects
DSL
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: configure messaging when creating services Safe-DS/DSL
1 participant
@lars-reimann