Improve EDA state #1169
Assignees
Labels
Comments
lars-reimann
added a commit
that referenced
this issue
May 16, 2024
Closes #1169 ### Summary of Changes - Split up the currentState into tabs, table and history stores, as no saving to vscode global state anymore so not needed to save as one big object - This means that svelte does not have to reevaluate so many things when something small changes, as in a new history item does not cause update to whole state anymore that causes table to update in background - Also easier to manage and update - tableIdentifier in table object, defaultState property not needed anymore and UserSettings not yet - columns don't have a number anymore as order is just array order - table filter is object that can have all the tablefilters but not multiple of one type - columnWidths still shall remain own store in component, as otherwise resize drag would cause massive amount of updates to the table store - setCurrentState msg is not setInitialTable and takes Table, error if executed more than once Co-authored-by: Lars Reimann <[email protected]>
|
🎉 This issue has been resolved in version 0.16.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem?
Messy state where any update to any part updates state as a whole. Some parts like column widths are kept in a store inside the components, while others are part of the big state object.
Desired solution
More separated into individual components and all the ones needed across components in the webviewstate.ts while the ones only needed in one defined and managed there. This will make the typing also cleaner and the extension will not have to insert placeholder data it should not really manage anyway like visible vs. total rows. Only possible because the state is not saved to vscodes global state anymore.
Possible alternatives (optional)
No response
Screenshots (optional)
No response
Additional Context (optional)
No response
The text was updated successfully, but these errors were encountered: