Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to hide and unhide some gems #17

Open
agrimm opened this issue Mar 9, 2016 · 4 comments
Open

Ability to hide and unhide some gems #17

agrimm opened this issue Mar 9, 2016 · 4 comments

Comments

@agrimm
Copy link

agrimm commented Mar 9, 2016

The overall problem I'm facing is having information overload associated with flamegraphs: http://stackoverflow.com/questions/35855922/dealing-with-information-overload-for-rack-mini-profiler-flamegraph

One approach for dealing with this (not mentioned in the SO question) may be to have the ability to click on a gem to hide (or unhide) gems. For example, I'd click on the "journey-1.0.4" gem and then the nodes for that would disappear. It'd probably be something like #7 (interactive legend) except with a different trigger and a different effect, and possibly something for hiding or unhiding all third party gems.

@SamSaffron
Copy link
Owner

@benoittgt
Copy link

Thanks a lot Sam for this answer. You clarify some points of flamegraph.

@etagwerker
Copy link

@SamSaffron Thanks for your explanation! I like @agrimm's idea. If I was interested in adding this feature to hide some gems/paths from the flame graph, where could I start? Somewhere in this file: https://github.com/SamSaffron/flamegraph/blob/master/lib/flamegraph/renderer.rb?

@SamSaffron
Copy link
Owner

@etagwerker all the rendering is done in javascript, so you would look there... I am open to more features that add flexibility, but if you are looking for radical changes keep an eye on #24 by @thisduck we plan to ship with multiple rendering engines soonish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants